Add Meriones unguiculatus to species list #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
+ Coverage 88.45% 88.54% +0.08%
==========================================
Files 78 78
Lines 10718 10718
==========================================
+ Hits 9481 9490 +9
+ Misses 1237 1228 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jwodder
requested changes
Nov 29, 2024
dandi/metadata/util.py
Outdated
| @@ -394,6 +394,12 @@ def extract_cellLine(metadata: dict) -> str | None: | |||
| NCBITAXON_URI_TEMPLATE.format("9545"), | |||
| "Macaca nemestrina", | |||
| ), | |||
| ( | |||
| ["Mongolian gerbil", "Mongolian jird"], | |||
There was a problem hiding this comment.
Suggested change
| ["Mongolian gerbil", "Mongolian jird"], | |
| ["mongolian gerbil", "mongolian jird"], |
There was a problem hiding this comment.
ideally IMHO we should make code robust to specification here and just .lower() then when matching. Or do you see an issue with that @jwodder ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: http://purl.obolibrary.org/obo/NCBITaxon_10047