[teammates/TEAMMATES] Issues Digest #3

github-actions · 2023-07-24T15:51:55Z

Subscribe to this issue to receive a periodic compilation of latest updates to this issue tracker.
Unsubscribe from this issue if you are not interested to receive such periodic updates.

github-actions · 2023-07-24T15:51:57Z

Digest Summary: 2023-07-24 23:51:57

... contains 16 changes across 7 issues, since 2023-07-14 23:51:56 (timezone: Singapore)

Instructor courses page: some items don't show spinners #10508

@rexong created this comment on 2023-07-16 14:22:38

Hi, can I start a PR for this?

@domlimm created this comment on 2023-07-16 14:36:27

@rexong Sure, feel free to submit a PR!

Instructor sending submission reminders: missing space between checkbox and label #12313

@Venkateeshh created this comment on 2023-07-16 18:46:02

Is anyone working on this issue still??

@weiquu created this comment on 2023-07-16 19:07:04

Nope, @Venkateeshh feel free to submit a PR for this issue

Refactoring of sortable tables #12329

@weiquu modified this issue on 2023-07-24 18:20:09

Sortable tables are used in several pages, but a fair number of them don't make use of the sortable-table component. Searching sortable amongst .html files should bring up these 10 (unlikely to be more, but best to do a more thorough search):

Extension confirm modal

Per question view responses

Sessions recycle bin table

Sessions table (Completed: #12501)

Student list

Notifications table

Copy instructors from other courses modal

Instructor courses page

Copy questions from other sessions modal

Instructor session individual extension page

It would be good to refactor the above components to make use of the sortable-table component to avoid duplication. Some other components, like the contribution question statistics component and the MCQ question statistic component, already make use of that component, so they can be referenced.

@singhabhyudita created this comment on 2023-07-20 09:36:25

Hi, I'll be taking up the Instructor courses page. Hope that's okay?

@weiquu created this comment on 2023-07-24 18:21:15

Hi, I'll be taking up the Instructor courses page. Hope that's okay?

Sure, do note the changes to the sortable-table component that was introduced in #12501

Flickering questions when loading sessions results #12499

@tushargupta123 created this comment on 2023-07-18 19:42:09

Hey can i correct the issue ?

@domlimm created this comment on 2023-07-18 19:43:33

@tushargupta123 Hello, feel free to submit a PR for this.

Nonspecific error messages on E2E tests #12513

@wkurniawan07 created this comment on 2023-07-16 16:37:57

This is not as simple as it sounds.

The nature of the verification is different: this is waiting for some event to happen, in this case for a toast with specified message to appear. Consider this scenario:

Toast with the modified message appears in page

Verification fails; wait for the specified timeout

Another toast with totally unrelated message appears in page

Verification fails

The suggested expected behaviour will compare the unrelated message, which is hardly any better. Granted that the chance of toast with unrelated message appearing is low, but it should show why it is not as simple as "show expected vs actual message".

V8.28.1 #12520

@damithc created and modified this issue on 2023-07-15 11:39:02

Scheduled for Saturday, Jul 15, 2023, ~~10.00pm~~ 10.00am SGT.

Release Lead:

Tagged the latest stable release code with the latest version number

Released changelogs

PM:

Deployed the new version

Released the new version for end users

@samuelfangjw created this comment on 2023-07-15 09:04:40

V8.28.1 has been released by @samuelfangjw at July 15th, 2023, 09.01am SGT.

Code contributions from: @Zxun2
Review contributions from: @domlimm, @weiquu

Ready for post-release check and deployment by PM (@damithc).

@damithc created this comment on 2023-07-15 11:39:21

Deployed and released. Thanks again for the quick patch release. 💯

Save all comments when saving responses for all questions #12527

@zhaojj2209 created this issue on 2023-07-22 23:34:02

Currently, the "Submit Responses to All Questions" button does not save comments. Given that comments for responses are now allowed for all question types (see #12426), it is all the more important that comments are saved along with the responses.

@Saimurugeshwari created this comment on 2023-07-24 04:43:36

can I work on this issue.

@jasonqiu212 created this comment on 2023-07-24 13:00:56

Hi @Saimurugeshwari, sure! Feel free to submit a PR for this issue

github-actions · 2023-07-26T12:38:30Z

Digest Summary: 2023-07-26 20:38:29

... contains 1 changes across 1 issues, since 2023-07-24 23:51:57 (timezone: Singapore)

Update tzdb version to 2023b or newer #12259

@weiquu created this comment on 2023-07-26 19:48:55

I believe this might be causing some issues with the E2E tests - will look into it and probably open a PR later tonight so we can resolve it quickly

github-actions · 2023-07-26T21:16:52Z

Digest Summary: 2023-07-27 05:16:52

... contains 1 changes across 1 issues, since 2023-07-26 20:38:30 (timezone: Singapore)

Instructor view session results (course-wide): Add separate button to download results by question #12283

@sunshinemoua created this comment on 2023-07-27 04:36:15

Hi, I would like to work on this issue. Please let me know if someone is already actively working on it. Thanks!

github-actions · 2023-07-27T09:19:12Z

Digest Summary: 2023-07-27 17:19:11

... contains 1 changes across 1 issues, since 2023-07-27 05:16:52 (timezone: Singapore)

Instructor view session results (course-wide): Add separate button to download results by question #12283

@weiquu created this comment on 2023-07-27 16:51:47

Hi ＠sunshinemoua, feel free to submit a PR for this issue

github-actions · 2023-07-29T14:18:23Z

Digest Summary: 2023-07-29 22:18:23

... contains 2 changes across 1 issues, since 2023-07-27 17:19:12 (timezone: Singapore)

Dark Theme #12529

@Anushka-Bhowmick created this issue on 2023-07-29 21:39:24

The website would look better if a dark theme and light theme feauture was incorporated.

@weiquu created this comment on 2023-07-29 21:54:41

Closing - duplicate of #11967

github-actions · 2023-07-30T08:22:01Z

Digest Summary: 2023-07-30 16:22:01

... contains 7 changes across 7 issues, since 2023-07-29 22:18:23 (timezone: Singapore)

Header: unable to expand dropdown with keyboard commands #12530

@weiquu created this issue on 2023-07-30 15:36:46

I'm able to tab over the dropdown buttons in the header, but pressing spacebar or enter/return doesn't expand the dropdown. This issue is present both for the "Help" dropdown as well as the user email dropdown (on the far right).

Other dropdowns are able to be expanded with either the spacebar or enter/return or both.

Header: "Log Out" button cannot be tabbed over #12531

@weiquu created this issue on 2023-07-30 15:39:13

In the header, I'm able to tab over all buttons except the "Log Out" button. After pressing tab, the button is skipped over and the browser focuses on the next button:

header.-.tab.not.working.mov

Instructor Home Page: Remind dropdown expands into the table #12532

@weiquu created this issue on 2023-07-30 15:47:43

In the instructor home page, clicking on the "Remind" dropdown causes the dropdown to be expanded within the table itself (rather than over it). This means that users have to scroll within the table in order to see the dropdown options. See below for screenshots (first is initial view, second is after scrolling within the table):

Note that the issue for some reason doesn't affect the "Results" button and I'm unable to recreate the issue on courses with more sessions:

Not sure if it's related to #12345

Instructor Home Page: tabbing doesn't work for most buttons on the Course dropdown #12533

@weiquu created this issue on 2023-07-30 15:53:10

The course dropdown in the course header panel is able to be opened, but I'm unable to tab to most of the buttons inside. Only the "View/Edit" button is able to be tabbed to; the rest are skipped over:

Screen.Recording.2023-07-30.at.3.49.46.PM.mov

Panels Tab Expandability #12534

@weiquu created this issue on 2023-07-30 15:59:40

Currently, panels are unable to be expanded by tabbing to it and pressing spacebar or enter/return (at least, I'm unable to find a way to do so). The root issue seems to be that they are not captured by the tab order. Not sure if we should try to implement a fix for this to make the site more accessible

Instructor Course Page: "Show" group cannot be tabbed over #12535

@weiquu created this issue on 2023-07-30 16:06:13

Under the "Active courses" table, each course has a "Show" group. Despite being similar to the session response rate "Show" cell, it is unable to be tabbed over and hence clicked via the keyboard:

Screen.Recording.2023-07-30.at.4.02.12.PM.mov

Instructor Search Page: sorting affects sort icons for all tables #12536

@weiquu created this issue on 2023-07-30 16:16:55

Sorting a table affects the sort icons for all tables. Note that only the sort icon is affected - the actual rows of the other tables aren't sorted.

Screen.Recording.2023-07-30.at.4.15.06.PM.mov

github-actions · 2023-07-30T09:16:59Z

Digest Summary: 2023-07-30 17:16:58

... contains 1 changes across 1 issues, since 2023-07-30 16:22:01 (timezone: Singapore)

Instructor Search Page: sorting affects sort icons for all tables #12536

@damithc created this comment on 2023-07-30 16:31:19

Good catch ＠weiquu
Let's raise the priority, as this is user-facing and makes the user view 'incorrect'

github-actions · 2023-07-30T11:15:05Z

Digest Summary: 2023-07-30 19:15:04

... contains 1 changes across 1 issues, since 2023-07-30 17:16:59 (timezone: Singapore)

Refactoring of sortable tables #12329

@domoberzin created this comment on 2023-07-30 18:42:02

Helllo, could I work on the student list component?

github-actions · 2023-07-30T16:23:53Z

github-actions · 2023-07-31T09:20:29Z

Digest Summary: 2023-07-31 17:20:28

... contains 1 changes across 1 issues, since 2023-07-31 00:23:53 (timezone: Singapore)

Instructor sessions page: Empty deleted sessions table is not displayed #12538

@jasonqiu212 created and modified this issue on 2023-07-31 16:48:13

Current Behavior

The instructor sessions page does not display an empty table of deleted feedback sessions, if there are no deleted sessions.

With deleted sessions:

No deleted sessions:

Expected Behavior

With reference to #10508:

I think empty tables should be shown even if there are no deleted/archived items. That's more consistent with our policy that even disabled items are shown to let users know where things are.

Suggestion

Add an alert for Deleted Sessions table when there are no deleted courses (Similar to #12521)

github-actions · 2023-07-31T12:41:25Z

Digest Summary: 2023-07-31 20:41:25

... contains 2 changes across 1 issues, since 2023-07-31 17:20:29 (timezone: Singapore)

Instructor sessions page: Empty deleted sessions table is not displayed #12538

@damithc created this comment on 2023-07-31 20:19:31

＠jasonqiu212 is this suitable for first timers?

@jasonqiu212 created and modified this comment on 2023-07-31 20:28:11

＠damithc Yes professor. Given that contributors can reference from #12521, I believe this is suitable for first-time contributors.

I will mark this issue as a "good first issue"

github-actions · 2023-07-31T15:22:23Z

github-actions · 2023-08-01T08:24:12Z

Digest Summary: 2023-08-01 16:24:11

... contains 1 changes across 1 issues, since 2023-07-31 23:22:23 (timezone: Singapore)

Instructor Home Page: Remind dropdown expands into the table #12532

@rexong created this comment on 2023-08-01 16:13:23

I would like to work on this.

github-actions · 2023-08-04T10:23:08Z

Digest Summary: 2023-08-04 18:23:08

... contains 1 changes across 1 issues, since 2023-08-01 16:24:12 (timezone: Singapore)

Instructor sessions page: Empty deleted sessions table is not displayed #12538

@mariemllr created this comment on 2023-08-04 18:23:02

Hi, can I contribute to this issue? :)

github-actions · 2023-08-04T11:16:08Z

Digest Summary: 2023-08-04 19:16:07

... contains 3 changes across 2 issues, since 2023-08-04 18:23:08 (timezone: Singapore)

Instructor sessions page: Empty deleted sessions table is not displayed #12538

@jasonqiu212 created this comment on 2023-08-04 19:06:45

Hi ＠mariemllr, Sure thing! Feel free to submit a PR for this issue

Cannot download results of session due to #12544

@damithc created this issue on 2023-08-04 18:44:51

V8.28.1
A user reported that downloading results fails silently.

Upon checking, I found that the download action causes this error to appear in the Browser console.

Seems to be related to a particular question. Trying to view the results of that question results in the above error as well. In addition, the results show up without some stats tables, as shown below:

The missing tables appear if I tick this checkbox.

The question itself is a follows:

The user has 6 courses with similar sessions. One can be downloaded without a problem but all other 5 has this problem.

Let me know if you need more information.

@samuelfangjw created this comment on 2023-08-04 19:11:21

Root cause is weight given to NEITE option is null/undefined instead of a number. Likely causing issues when calculating per recipient stats.

github-actions · 2023-08-04T12:36:45Z

Digest Summary: 2023-08-04 20:36:45

... contains 1 changes across 1 issues, since 2023-08-04 19:16:08 (timezone: Singapore)

Cannot download results of session due to #12544

@samuelfangjw created and modified this comment on 2023-08-04 19:22:11

https://github.com/TEAMMATES/teammates/blob/5bc54fc63c6f8f37e8f26d46d5217555ab65f7d8/src/web/app/components/question-types/question-statistics/question-statistics-calculation/rubric-question-statistics-calculation.ts#L126

More specifically, subAnswer here is undefined. The rubrics question type doesn't seem to have been designed with the null use case in mind, but certainly can be added if we need a quick fix to this problem.

One solution could be to ignore options that are null/undefined when calculating statistics, though care should be taken to ensure that the number of responses and the statistics calculation is not affected.

github-actions · 2023-08-04T13:22:44Z

Digest Summary: 2023-08-04 21:22:43

... contains 1 changes across 1 issues, since 2023-08-04 20:36:45 (timezone: Singapore)

Cannot download results of session due to #12544

@damithc created this comment on 2023-08-04 21:20:22

Thanks for investigating this, ＠samuelfangjw

Root cause is weight given to NEITE option is null/undefined instead of a number. Likely causing issues when calculating per recipient stats.

The funny thing is, a similar session in the one (out of five) course doesn't have this problem. Given below is the corresponding question from the session that doesn't have this problem.

Perhaps only certain responses to this question triggers this problem? In that case it is possible that one of six sessions doesn't have that 'trigger' data.

github-actions · 2023-08-04T14:20:45Z

Digest Summary: 2023-08-04 22:20:45

... contains 5 changes across 1 issues, since 2023-08-04 21:22:44 (timezone: Singapore)

Cannot download results of session due to #12544

@samuelfangjw created this comment on 2023-08-04 21:23:32

Thanks for investigating this, ＠samuelfangjw

Root cause is weight given to NEITE option is null/undefined instead of a number. Likely causing issues when calculating per recipient stats.

The funny thing is, a similar session in the one (out of five) course doesn't have this problem. Given below is the corresponding question from the session that doesn't have this problem.

Perhaps only certain responses to this question triggers this problem? In that case it is possible that one of six sessions doesn't have that 'trigger' data.

I believe it would be possible if the question has no responses that have selected the null option.

@damithc created this comment on 2023-08-04 21:25:59

I believe it would be possible if the question has no responses that have selected the null option.

Yup, this seems to be the case. Respondents have chosen the NEITE option in the problematic sessions but no one has chosen it in the session that works.

@damithc created this comment on 2023-08-04 21:28:23

Would adding a weight to that column fix the problem? Also, would it wipe out the existing responses?

@samuelfangjw created this comment on 2023-08-04 21:38:42

Would adding a weight to that column fix the problem? Also, would it wipe out the existing responses?

Not sure if it will wipe existing responses, we will have to look into it.

Adding a weight will fix it, but my concern is that there doesn't seem to be an appropriate weight to assign to the option.

@damithc created this comment on 2023-08-04 21:41:55

but my concern is that there doesn't seem to be an appropriate weight to assign to the option.

Good point.

github-actions · 2023-08-05T04:22:10Z

Digest Summary: 2023-08-05 12:22:09

... contains 1 changes across 1 issues, since 2023-08-04 22:20:45 (timezone: Singapore)

Cannot download results of session due to #12544

@damithc created this comment on 2023-08-05 11:31:02

We need to get someone working on this quickly, as the user is stuck with un-downloadable results.

github-actions · 2023-08-05T05:19:50Z

Digest Summary: 2023-08-05 13:19:50

... contains 1 changes across 1 issues, since 2023-08-05 12:22:10 (timezone: Singapore)

Cannot download results of session due to #12544

@jasonqiu212 created this comment on 2023-08-05 13:17:40

I can work on this issue.

I will follow ＠samuelfangjw's proposed solution:

One solution could be to ignore options that are null/undefined when calculating statistics, though care should be taken to ensure that the number of responses and the statistics calculation is not affected.

github-actions · 2023-08-05T06:22:55Z

Digest Summary: 2023-08-05 14:22:54

... contains 1 changes across 1 issues, since 2023-08-05 13:19:50 (timezone: Singapore)

Cannot download results of session due to #12544

@damithc created this comment on 2023-08-05 13:43:08

I can work on this issue.

I will follow ＠samuelfangjw's proposed solution:

One solution could be to ignore options that are null/undefined when calculating statistics, though care should be taken to ensure that the number of responses and the statistics calculation is not affected.

Great. Thanks ＠jasonqiu212

github-actions · 2023-08-05T09:16:43Z

Digest Summary: 2023-08-05 17:16:42

... contains 1 changes across 1 issues, since 2023-08-05 14:22:55 (timezone: Singapore)

Cannot download results of session due to #12544

@jasonqiu212 created this comment on 2023-08-05 16:57:22

Update:

Assign null weights to special constant of NO_VALUE

Skip over null weights when calculating average weight stats

Testing

Will finish PR by tonight!

github-actions · 2023-08-05T15:17:51Z

Digest Summary: 2023-08-05 23:17:50

... contains 1 changes across 1 issues, since 2023-08-05 17:16:43 (timezone: Singapore)

Cannot download results of session due to #12544

@jasonqiu212 modified this comment on 2023-08-05 22:42:18

Update:

Assign null weights to special constant of NO_VALUE

Skip over null weights when calculating average weight stats

Testing

Will finish PR by tonight!

github-actions · 2023-08-05T16:23:30Z

Digest Summary: 2023-08-06 00:23:29

... contains 2 changes across 1 issues, since 2023-08-05 23:17:51 (timezone: Singapore)

Empty weights for MCQ #12547

@jasonqiu212 created and modified this issue on 2023-08-05 23:19:20

V8.28.1

With reference to #12544, it is possible to add empty weights (i.e. Leave the input box for weight empty) for rubric questions. The issue demonstrates that empty weights can be a valid feature. They can be used for:

Rubric options that do not have a suitable numerical weight

Rubric options that the user does not want to be calculated in the average weight statistics

Weights are also present in MCQ (single answer) and MCQ (multiple answers). However, both question types currently do not allow users to save with empty weights:

Should empty weights be allowed for MCQ (single answer) and MCQ (multiple answers) too? Here's a possible use case:

Question: "Do you think this class is helpful?" with the options of:

Not enough information to evaluate

Disagree

Agree

It's difficult to assign a numerical weight to the 1st option.

@damithc created this comment on 2023-08-05 23:31:32

Should empty weights be allowed for MCQ (single answer) and MCQ (multiple answers) too? Here's a possible use case:

Question: "Do you think this class is helpful?" with the options of:

Not enough information to evaluate

Disagree

Agree

It's difficult to assign a numerical weight to the 1st option.

＠jasonqiu212 Yes, I think this is a legit use case.

github-actions · 2023-08-06T07:16:44Z

Digest Summary: 2023-08-06 15:16:44

... contains 2 changes across 1 issues, since 2023-08-06 00:23:30 (timezone: Singapore)

Feedback issue #12548

@Rajansharma44 created this issue on 2023-08-06 14:34:22

Environment:

Description of feature/enhancement

Justification

Existing similar features and their shortcomings

@Rajansharma44 created this comment on 2023-08-06 14:35:18

can you explain the feedback form.

github-actions · 2023-08-06T18:21:54Z

Digest Summary: 2023-08-07 02:21:53

... contains 1 changes across 1 issues, since 2023-08-06 15:16:44 (timezone: Singapore)

Instructor home page loads forever if attempt to copy a feedback sessions fail #12507

@rexong created this comment on 2023-08-07 02:06:59

I would like to try this issue.

github-actions · 2023-08-09T14:23:47Z

Digest Summary: 2023-08-09 22:23:47

... contains 1 changes across 1 issues, since 2023-08-07 02:21:54 (timezone: Singapore)

Instructor Session Page: Failed copy feedback session causes page to load forever. #12551

@rexong created this issue on 2023-08-09 22:21:53

Environment:
master branch at commit 8633d4e

Problem
The issue is similar/identical to the issue #12507.
When we try to copy the feedback session, if it fails, it will lead to the page loading forever. The only way to stop it is through hard refresh or navigating to another page.

Steps to reproduce

Go to instructor session page.

Click on Copy for any available session.

Select the same course as the selected session.

Click Copy.

Expected behaviour

Error toast to be shown

Session table should be generated.

Actual behaviour
Page goes into a loading state forever.

Video Demo of Actual Behaviour
https://github.com/TEAMMATES/teammates/assets/66376253/74e424cd-ef1c-4d02-9aef-7d0d9199277c

Additional info

As mentioned, this issue is similar to issue #12507.
To resolve this issue, look at PR #12550

github-actions · 2023-08-09T15:23:12Z

Digest Summary: 2023-08-09 23:23:12

... contains 1 changes across 1 issues, since 2023-08-09 22:23:47 (timezone: Singapore)

Session Copy Modal: Instructors able to select the Course that they are copying from #12552

@rexong created this issue on 2023-08-09 22:36:06

Environment:

master branch at commit 8633d4e

Steps to reproduce
Given that there is a session call First team feedback session (percentage-based) from test.tes-demo course.

Navigate to Instructor Session Page.

Click on the Copy button of First team feedback session (percentage-based)

Select test.tes-demo as the course to copy to.

Video Demo

TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2023-08-09.22-14-20.mp4

Current behaviour
Error will be shown stating that the session is already in the course.

Suggestions
Perhaps the instructor should not be allowed to copy the session into the same course.
This could be resolved by either

Remove the selection for the same course, ie not displaying the same course as a choice

Disable the selection for the same course, ie displaying the same course as a choice, but not allowing instructors to select it.

github-actions · 2023-08-10T10:24:56Z

Digest Summary: 2023-08-10 18:24:56

... contains 1 changes across 1 issues, since 2023-08-09 23:23:12 (timezone: Singapore)

Flickering questions when loading sessions results #12499

@rajatmohan22 created this comment on 2023-08-10 17:55:38

＠domlimm Hi, is this issue already assigned to someone? because if not i'll definitely contribute a PR within the next 2-3 days

github-actions · 2023-08-10T11:17:13Z

Digest Summary: 2023-08-10 19:17:12

... contains 1 changes across 1 issues, since 2023-08-10 18:24:56 (timezone: Singapore)

Flickering questions when loading sessions results #12499

@jasonqiu212 created this comment on 2023-08-10 18:59:25

Hi ＠rajatmohan22, feel free to submit a PR for this issue!

github-actions · 2023-10-20T12:37:37Z

Digest Summary: 2023-10-20 20:37:37

... contains 10 changes across 9 issues, since 2023-10-20 19:16:53 (timezone: Singapore)

Create Unit Tests for Feedback*QuestionDetails classes #1501

@u6516595 created this comment on 2023-10-20 19:56:55

Hello,I'm a beginner. Can I work on it?

Data Migration: feedback session timestamps #12359

@anjum-edge created this comment on 2023-10-20 19:48:29

XX 58 have some bugs because XX 59 is connected to the 58th one
so make sure to look out for the bugs in that before proceeding to YY part

Some users seeing old versions of TEAMMATES? #12367

@anjum-edge created this comment on 2023-10-20 19:57:41

Update the links in the ahrefs part to get it done

Set character limit on question description #12460

@anjum-edge created this comment on 2023-10-20 19:55:52

Set the character limit to 1000 words to get it done without any problems because the more words you add the more irrelevent it becomes.
Maintain the simplicity that's it

Add Sort Functions to Admin Sessions Page #12467

@anjum-edge created this comment on 2023-10-20 19:42:41

PR may have bugs

Panels Tab Expandability #12534

@anjum-edge created this comment on 2023-10-20 19:38:03

Add new features in chevrons because the tab order content can be shown once to show it single to multiple times. Original functionality can be changed because the changes in the code can be done and visible online so make sure to take care of that.

Improve test code coverage of core components #12588

@anjum-edge created this comment on 2023-10-20 19:32:53

Please test LogsTableContent again because it can contain bugs
Also check AddQuestionComponent because a new part of it can be deployed and can check the issues

Cannot add more individual deadline extensions while some are ongoing #12594

@anjum-edge created this comment on 2023-10-20 19:25:07

The Long term fix can be important because it effects in the long term performance and fix extension bugs to see long term effects

@damithc created this comment on 2023-10-20 20:01:10

＠anjum-edge please refrain from spam posting

Check for the bugs in the html part of the website and analyse it #12614

@anjum-edge created this issue on 2023-10-20 19:49:39

Environment:

Steps to reproduce

Expected behaviour

Actual behaviour

Additional info

github-actions · 2023-10-20T14:21:54Z

Digest Summary: 2023-10-20 22:21:54

... contains 1 changes across 1 issues, since 2023-10-20 20:37:37 (timezone: Singapore)

Student viewing results of a contribution question: (i) icon doesn't look clickable #12607

@Jiaqi093 created this comment on 2023-10-20 21:37:52

Hi, may I be assigned to this issue?

github-actions · 2023-10-21T05:20:56Z

Digest Summary: 2023-10-21 13:20:56

... contains 1 changes across 1 issues, since 2023-10-20 22:21:54 (timezone: Singapore)

Improve test code coverage of core components #12588

@090997 created this comment on 2023-10-21 12:36:15

Hi,could I work on LogsHistogramComponent and LogsTableComponent Testing?

hello ＠090997, unfortunately these have been taken already

＠cedricongjh Hi,Is there any other components that I can try to test?

github-actions · 2023-10-21T08:22:19Z

Digest Summary: 2023-10-21 16:22:18

... contains 1 changes across 1 issues, since 2023-10-21 13:20:56 (timezone: Singapore)

Navbar in mobile view broken #11860

@fishchimp created this comment on 2023-10-21 16:11:21

Hi, I've been experimenting with different AVDs on different browsers on top of my device (iPhone 11 Pro Max on IOS 17, tested on Safari, Chrome, and Firefox). This bug seems to have been fixed as of Teammates V.8.29.0. Though I don't know if it's because of an update from the browsers or one of the newer releases for Teammates or if I'm not replicating the bug correctly.

github-actions · 2023-10-21T10:22:16Z

Digest Summary: 2023-10-21 18:22:15

... contains 1 changes across 1 issues, since 2023-10-21 16:22:19 (timezone: Singapore)

Missing loading icons and bugs #10569

@Lucas-longxutang created this comment on 2023-10-21 18:07:34

Hi, may I be assigned to this issue? I would like to work on Instructor Sessions Page, delete button.

github-actions · 2023-10-21T12:34:24Z

Digest Summary: 2023-10-21 20:34:24

... contains 1 changes across 1 issues, since 2023-10-21 18:22:16 (timezone: Singapore)

Missing loading icons and bugs #10569

@domlimm created this comment on 2023-10-21 19:15:37

＠Lucas-longxutang Hello, we do not assign issues to contributors. Feel free to submit a PR for this issue! 😄

github-actions · 2023-10-21T13:20:10Z

Digest Summary: 2023-10-21 21:20:10

... contains 3 changes across 3 issues, since 2023-10-21 20:34:24 (timezone: Singapore)

Empty weights for MCQ #12547

@090997 created this comment on 2023-10-21 21:13:15

Hi, I am interest on this issue. Can I work for this? ＠jasonqiu212

Instructor Edit Student Response Page: Missing Header Navbar #12584

@Miranda-lrx created this comment on 2023-10-21 20:59:31

Hi, could I try this issue please?
U7763307, workshop10

Student viewing results of a contribution question: (i) icon doesn't look clickable #12607

@Zhouheng98 created this comment on 2023-10-21 20:49:33

Hi, I am a student, can I try to solve this problem?

github-actions · 2023-10-21T14:19:19Z

Digest Summary: 2023-10-21 22:19:19

... contains 4 changes across 3 issues, since 2023-10-21 21:20:10 (timezone: Singapore)

Create Unit Tests for Feedback*QuestionDetails classes #1501

@cedricongjh created this comment on 2023-10-21 21:43:19

hi ＠YinyinChencr7 and ＠u6516595, you can try to run the related test files with code coverage to see if there is any missing test coverage in the respective class, and submit a PR to add the tests if there are any missing

Improve test code coverage of core components #12588

@cedricongjh modified this issue on 2023-10-21 21:50:40

Description of feature/enhancement
The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)

Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested

Submit the PR, link it to this issue by starting the description with "Part of #12588"

Components:

Component Assignee Codecov PR

AddingQuestionPanelComponent ＠blejkowski link -

CommentEditFormComponent ＠HarryLu33 link TEAMMATES/teammates#12604

CommentRowComponent ＠ThomasGreen123 link -

CommentTableComponent ＠u7505884 link -

CommentTableModalComponent ＠kenneySiu link TEAMMATES/teammates#12609

CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe ＠cedricongjh link1, link2, link3, link4 TEAMMATES/teammates#12589

CopyCourseModalComponent ＠cedricongjh link TEAMMATES/teammates#12590

CopySessionModalComponent ＠Astrid641 link -

CourseEditFormComponent ＠lunoos link TEAMMATES/teammates#12597

DatepickerComponent ＠dlimyy link TEAMMATES/teammates#12592

DatePickerFormatter ＠dlimyy link TEAMMATES/teammates#12593

ErrorReportComponent ＠u7488099 link TEAMMATES/teammates#12610

ExtensionConfirmModalComponent ＠MatheuMa link -

FeedbackPathPanelComponent ＠JYH11 link -

LogsHistogramComponent ＠Miranda-lrx link -

LogsTableComponent ＠sdpunit link -

LogsDetails ＠nikkixiong link -

LogsLine ＠090997 link -

@cedricongjh created this comment on 2023-10-21 21:51:10

hi ＠090997 i've assigned you LogsLine for you to try to test

Student viewing results of a contribution question: (i) icon doesn't look clickable #12607

@cedricongjh created this comment on 2023-10-21 21:35:19

hi ＠Jiaqi093 and ＠Zhouheng98, let's give ＠nikkixiong time to submit a PR

＠nikkixiong do let us know if you're still working on this, thank you!

github-actions · 2023-10-21T21:16:08Z

Digest Summary: 2023-10-22 05:16:08

... contains 1 changes across 1 issues, since 2023-10-21 22:19:19 (timezone: Singapore)

Instructor Edit Student Response Page: Missing Header Navbar #12584

@1911-revo created this comment on 2023-10-22 04:44:59

Hi, I am afraid that you have better try another issue since we are in the same workshop.
Thanks for your understanding.

github-actions · 2023-10-22T03:20:41Z

Digest Summary: 2023-10-22 11:20:41

... contains 1 changes across 1 issues, since 2023-10-22 05:16:08 (timezone: Singapore)

Improve test code coverage of core components #12588

@nikkixiong created this comment on 2023-10-22 10:56:27

＠cedricongjh I already finished the LogsDetails testing and got all 100% covered on my computer, I will request for a PR soon.

github-actions · 2023-10-22T07:16:34Z

Digest Summary: 2023-10-22 15:16:33

... contains 1 changes across 1 issues, since 2023-10-22 11:20:41 (timezone: Singapore)

Instructor extending individual deadlines: table doesn't sort by team #12596

@wanqiqiu created this comment on 2023-10-22 14:33:23

hi, ＠cedricongjh can I work on this issue to have a try? Thank you!
(uid: u7503408 for reference.)

github-actions · 2023-10-22T19:15:35Z

Digest Summary: 2023-10-23 03:15:34

... contains 2 changes across 2 issues, since 2023-10-22 15:16:34 (timezone: Singapore)

Improve test code coverage of core components #12588

@cedricongjh modified this issue on 2023-10-23 03:11:41

Description of feature/enhancement
The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)

Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested

Submit the PR, link it to this issue by starting the description with "Part of #12588"

Components:

Component Assignee Codecov PR

AddingQuestionPanelComponent ＠blejkowski link -

CommentEditFormComponent ＠HarryLu33 link TEAMMATES/teammates#12604

CommentRowComponent ＠ThomasGreen123 link TEAMMATES/teammates#12612

CommentTableComponent ＠u7505884 link -

CommentTableModalComponent ＠kenneySiu link TEAMMATES/teammates#12609

CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe ＠cedricongjh link1, link2, link3, link4 TEAMMATES/teammates#12589

CopyCourseModalComponent ＠cedricongjh link TEAMMATES/teammates#12590

CopySessionModalComponent ＠Astrid641 link -

CourseEditFormComponent ＠lunoos link TEAMMATES/teammates#12597

DatepickerComponent ＠dlimyy link TEAMMATES/teammates#12592

DatePickerFormatter ＠dlimyy link TEAMMATES/teammates#12593

ErrorReportComponent ＠u7488099 link TEAMMATES/teammates#12610

ExtensionConfirmModalComponent ＠MatheuMa link -

FeedbackPathPanelComponent ＠JYH11 link TEAMMATES/teammates#12613

LogsHistogramComponent ＠Miranda-lrx link -

LogsTableComponent ＠sdpunit link -

LogsDetails ＠nikkixiong link TEAMMATES/teammates#12618

LogsLine ＠090997 link -

Instructor extending individual deadlines: table doesn't sort by team #12596

@cedricongjh created this comment on 2023-10-23 02:52:20

hi ＠Ruimeng-Ye and ＠wanqiqiu, since ＠rameshmoorjani has expressed interest in this issue, let's give him time to work on it, you're welcome to look into other issues to contribute to!

＠rameshmoorjani do let us know if you're still working on it, thank you!

github-actions · 2023-10-22T23:18:49Z

Digest Summary: 2023-10-23 07:18:49

... contains 1 changes across 1 issues, since 2023-10-23 03:15:35 (timezone: Singapore)

Instructor extending individual deadlines: table doesn't sort by team #12596

@rameshmoorjani created this comment on 2023-10-23 06:32:54

＠cedricongjh - yes I am working on it, having some issue with setup in local due to ng-in-viewport and Agular version mismatch. I will update asap.

github-actions · 2023-10-26T08:24:27Z

Digest Summary: 2023-10-26 16:24:27

... contains 1 changes across 1 issues, since 2023-10-23 07:18:49 (timezone: Singapore)

Student viewing results of a contribution question: (i) icon doesn't look clickable #12607

@Jiaqi093 created this comment on 2023-10-26 16:03:22

Hi, I just submit a PR, could you please review it?

github-actions · 2023-10-26T10:23:58Z

Digest Summary: 2023-10-26 18:23:57

... contains 2 changes across 2 issues, since 2023-10-26 16:24:27 (timezone: Singapore)

Give respondents a way to reset a rubric question submission #12508

@erinmayfield created this comment on 2023-10-26 18:02:45

Hi, could I please work on this issue as well?
u7317656,w10

Improve test code coverage of core components #12588

@ThomasGreen123 created and modified this comment on 2023-10-26 17:23:32

＠cedricongjh，Can try to test question-response-panel.component.ts?

github-actions · 2023-10-26T15:20:24Z

Digest Summary: 2023-10-26 23:20:23

... contains 2 changes across 1 issues, since 2023-10-26 18:23:58 (timezone: Singapore)

Improve test code coverage of core components #12588

@cedricongjh modified this issue on 2023-10-26 23:06:38

Description of feature/enhancement
The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)

Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested

Submit the PR, link it to this issue by starting the description with "Part of #12588"

Components:

Component Assignee Codecov PR

AddingQuestionPanelComponent ＠ThomasGreen123 link -

CommentEditFormComponent ＠HarryLu33 link TEAMMATES/teammates#12604

CommentRowComponent ＠ThomasGreen123 link TEAMMATES/teammates#12612

CommentTableComponent ＠u7505884 link -

CommentTableModalComponent ＠kenneySiu link TEAMMATES/teammates#12609

CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe ＠cedricongjh link1, link2, link3, link4 TEAMMATES/teammates#12589

CopyCourseModalComponent ＠cedricongjh link TEAMMATES/teammates#12590

CopySessionModalComponent ＠Astrid641 link -

CourseEditFormComponent ＠lunoos link TEAMMATES/teammates#12597

DatepickerComponent ＠dlimyy link TEAMMATES/teammates#12592

DatePickerFormatter ＠dlimyy link TEAMMATES/teammates#12593

ErrorReportComponent ＠u7488099 link TEAMMATES/teammates#12610

ExtensionConfirmModalComponent ＠MatheuMa link -

FeedbackPathPanelComponent ＠JYH11 link TEAMMATES/teammates#12613

LogsHistogramComponent ＠Miranda-lrx link -

LogsTableComponent ＠sdpunit link -

LogsDetails ＠nikkixiong link TEAMMATES/teammates#12618

LogsLine ＠090997 link -

@cedricongjh created this comment on 2023-10-26 23:06:26

hey ＠ThomasGreen123, feel free to take AddingQuestionPanelComponent

github-actions · 2023-10-26T16:25:10Z

Digest Summary: 2023-10-27 00:25:09

... contains 1 changes across 1 issues, since 2023-10-26 23:20:24 (timezone: Singapore)

Improve test code coverage of core components #12588

@kenneySiu created this comment on 2023-10-27 00:11:53

Hi ＠cedricongjh I would also like to take on more tests if you have any available

github-actions · 2023-10-26T17:20:39Z

Digest Summary: 2023-10-27 01:20:39

... contains 2 changes across 1 issues, since 2023-10-27 00:25:10 (timezone: Singapore)

Improve test code coverage of core components #12588

@sdpunit created this comment on 2023-10-27 00:27:07

hey

hey ＠ThomasGreen123, feel free to take AddingQuestionPanelComponent

Hey ＠cedricongjh I am working on AddingQuestionPanelComponent as well, since there wasn't any response from ＠blejkowski. However, I am happy for ＠ThomasGreen123 to work on it if he submits a PR before me, I'll request one tomorrow for LogsTableComponent and AddingQuestionPanelComponent subsequently.

@cedricongjh created this comment on 2023-10-27 00:28:39

hey

hey ＠ThomasGreen123, feel free to take AddingQuestionPanelComponent

Hey ＠cedricongjh I am working on AddingQuestionPanelComponent as well, since there wasn't any response from ＠blejkowski. However, I am happy for ＠ThomasGreen123 to work on it if he submits a PR before me, I'll request one tomorrow for LogsTableComponent and AddingQuestionPanelComponent subsequently.

ah my bad! you can take that!

＠ThomasGreen123, ＠kenneySiu give me a moment, i'll find new components for you to work on!

github-actions · 2023-10-26T19:15:37Z

Digest Summary: 2023-10-27 03:15:36

... contains 2 changes across 1 issues, since 2023-10-27 01:20:39 (timezone: Singapore)

Improve test code coverage of core components #12588

@cedricongjh modified this issue on 2023-10-27 02:34:14

Description of feature/enhancement
The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)

Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested

Submit the PR, link it to this issue by starting the description with "Part of #12588"

Components:

Component Assignee Codecov PR

AddingQuestionPanelComponent ＠ThomasGreen123 link -

CommentEditFormComponent ＠HarryLu33 link TEAMMATES/teammates#12604

CommentRowComponent ＠ThomasGreen123 link TEAMMATES/teammates#12612

CommentTableComponent ＠u7505884 link -

CommentTableModalComponent ＠kenneySiu link TEAMMATES/teammates#12609

CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe ＠cedricongjh link1, link2, link3, link4 TEAMMATES/teammates#12589

CopyCourseModalComponent ＠cedricongjh link TEAMMATES/teammates#12590

CopySessionModalComponent ＠Astrid641 link -

CourseEditFormComponent ＠lunoos link TEAMMATES/teammates#12597

DatepickerComponent ＠dlimyy link TEAMMATES/teammates#12592

DatePickerFormatter ＠dlimyy link TEAMMATES/teammates#12593

ErrorReportComponent ＠u7488099 link TEAMMATES/teammates#12610

ExtensionConfirmModalComponent ＠MatheuMa link -

FeedbackPathPanelComponent ＠JYH11 link TEAMMATES/teammates#12613

LogsHistogramComponent ＠Miranda-lrx link -

LogsTableComponent ＠sdpunit link -

LogsDetails ＠nikkixiong link TEAMMATES/teammates#12618

LogsLine ＠090997 link -

QuestionSubmissionForm ＠ThomasGreen123 link -

SessionEditForm ＠kenneySiu link -

@cedricongjh created this comment on 2023-10-27 02:34:46

hey ＠ThomasGreen123 and ＠kenneySiu i've assigned new components for you to work on! thank you for taking them up

github-actions · 2023-10-27T03:19:42Z

Digest Summary: 2023-10-27 11:19:41

... contains 1 changes across 1 issues, since 2023-10-27 03:15:37 (timezone: Singapore)

gradle build failing at the test task #12625

@aditya4196 created this issue on 2023-10-27 10:52:38

Im trying to setup the teammates project on my local, I ran the ./gradlew build, and it is failing in the test task with below error for all the tests

teammates.common.datatransfer.questions.FeedbackRubricQuestionDetailsTest > initializationError FAILED
org.junit.runners.model.InvalidTestClassError at ParentRunner.java:525

Can anyone help me?

github-actions · 2023-10-27T08:23:57Z

Digest Summary: 2023-10-27 16:23:56

... contains 1 changes across 1 issues, since 2023-10-27 11:19:42 (timezone: Singapore)

Instructor Edit Student Response Page: Missing Header Navbar #12584

@u7452980 created this comment on 2023-10-27 15:49:38

Hi ＠kenny10280703 , I'd like to ask what classes are involved for java backend and which typescripts are relevant to this issue?

github-actions · 2023-10-27T13:22:11Z

Digest Summary: 2023-10-27 21:22:10

... contains 1 changes across 1 issues, since 2023-10-27 16:23:57 (timezone: Singapore)

Student viewing results of a contribution question: (i) icon doesn't look clickable #12607

@saurabhje created this comment on 2023-10-27 20:59:05

If its still not fixed let me know.

github-actions · 2023-10-27T15:20:07Z

Digest Summary: 2023-10-27 23:20:06

... contains 1 changes across 1 issues, since 2023-10-27 21:22:11 (timezone: Singapore)

Improve test code coverage of core components #12588

@cedricongjh modified this issue on 2023-10-27 22:39:24

Description of feature/enhancement
The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)

Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested

Submit the PR, link it to this issue by starting the description with "Part of #12588"

Components:

Component Assignee Codecov PR

AddingQuestionPanelComponent ＠sdpunit link -

CommentEditFormComponent ＠HarryLu33 link TEAMMATES/teammates#12604

CommentRowComponent ＠ThomasGreen123 link TEAMMATES/teammates#12612

CommentTableComponent ＠u7505884 link -

CommentTableModalComponent ＠kenneySiu link TEAMMATES/teammates#12609

CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe ＠cedricongjh link1, link2, link3, link4 TEAMMATES/teammates#12589

CopyCourseModalComponent ＠cedricongjh link TEAMMATES/teammates#12590

CopySessionModalComponent ＠Astrid641 link -

CourseEditFormComponent ＠lunoos link TEAMMATES/teammates#12597

DatepickerComponent ＠dlimyy link TEAMMATES/teammates#12592

DatePickerFormatter ＠dlimyy link TEAMMATES/teammates#12593

ErrorReportComponent ＠u7488099 link TEAMMATES/teammates#12610

ExtensionConfirmModalComponent ＠MatheuMa link -

FeedbackPathPanelComponent ＠JYH11 link TEAMMATES/teammates#12613

LogsHistogramComponent ＠Miranda-lrx link -

LogsTableComponent ＠sdpunit link -

LogsDetails ＠nikkixiong link TEAMMATES/teammates#12618

LogsLine ＠090997 link -

QuestionSubmissionForm ＠ThomasGreen123 link -

SessionEditForm ＠kenneySiu link -

github-actions · 2023-10-28T19:14:23Z

Digest Summary: 2023-10-29 03:14:22

... contains 4 changes across 4 issues, since 2023-10-27 23:20:07 (timezone: Singapore)

Instructor Edit Student Response Page: Missing Header Navbar #12584

@cedricongjh created this comment on 2023-10-29 02:44:57

this is not an issue, as the design of this is intentional, thus we'll be closing this issue

Improve test code coverage of core components #12588

@cedricongjh modified this issue on 2023-10-29 02:56:50

Description of feature/enhancement
The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)

Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested

Submit the PR, link it to this issue by starting the description with "Part of #12588"

Components:

Component Assignee Codecov PR

AddingQuestionPanelComponent ＠sdpunit link -

CommentEditFormComponent ＠HarryLu33 link TEAMMATES/teammates#12604

CommentRowComponent ＠ThomasGreen123 link TEAMMATES/teammates#12612

CommentTableComponent ＠u7505884 link -

CommentTableModalComponent ＠kenneySiu link TEAMMATES/teammates#12609

CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe ＠cedricongjh link1, link2, link3, link4 TEAMMATES/teammates#12589

CopyCourseModalComponent ＠cedricongjh link TEAMMATES/teammates#12590

CopySessionModalComponent ＠Astrid641 link -

CourseEditFormComponent ＠lunoos link TEAMMATES/teammates#12597

DatepickerComponent ＠dlimyy link TEAMMATES/teammates#12592

DatePickerFormatter ＠dlimyy link TEAMMATES/teammates#12593

ErrorReportComponent ＠u7488099 link TEAMMATES/teammates#12610

ExtensionConfirmModalComponent ＠MatheuMa link TEAMMATES/teammates#12622

FeedbackPathPanelComponent ＠JYH11 link TEAMMATES/teammates#12613

LogsHistogramComponent ＠Miranda-lrx link -

LogsTableComponent ＠sdpunit link -

LogsDetails ＠nikkixiong link TEAMMATES/teammates#12618

LogsLine ＠090997 link -

RecipientTypeNamePipe ＠ThomasGreen123 link TEAMMATES/teammates#12626

SessionEditForm ＠kenneySiu link -

Student viewing results of a contribution question: (i) icon doesn't look clickable #12607

@cedricongjh created this comment on 2023-10-29 02:48:26

hi ＠saurabhje there's already an open PR for this issue, you're welcome to find other issues to contribute to

gradle build failing at the test task #12625

@cedricongjh created this comment on 2023-10-29 02:40:17

hi ＠aditya4196 the command for running the project is ./gradlew serverRun, do try that out and let us know if you run into any issues

github-actions · 2023-10-30T01:20:55Z

Digest Summary: 2023-10-30 09:20:54

... contains 1 changes across 1 issues, since 2023-10-29 03:14:23 (timezone: Singapore)

gradle build failing at the test task #12625

@aditya4196 created this comment on 2023-10-30 07:23:27

Thanks ＠cedricongjh
I was able to start the application
I would like to contribute to this project. Im gonna go through some issues but incase there is anything to do, please assign it to me.

github-actions · 2023-10-30T10:24:59Z

Digest Summary: 2023-10-30 18:24:59

... contains 1 changes across 1 issues, since 2023-10-30 09:20:55 (timezone: Singapore)

gradle build failing at the test task #12625

@cedricongjh created this comment on 2023-10-30 18:07:05

Thanks ＠cedricongjh I was able to start the application I would like to contribute to this project. Im gonna go through some issues but incase there is anything to do, please assign it to me.

great to hear! we'll proceed to close this issue

github-actions · 2023-10-31T12:37:09Z

Digest Summary: 2023-10-31 20:37:09

... contains 1 changes across 1 issues, since 2023-10-30 18:24:59 (timezone: Singapore)

Instructor courses page: other actions dropdown cut off #12345

@manojkumar20k3 created this comment on 2023-10-31 19:52:06

Hello, I am a beginner in open source contribution. Is this issue open ? If it's open please assign it to me ,So that i can make my first contribution .

github-actions · 2023-11-01T15:21:06Z

Digest Summary: 2023-11-01 23:21:06

... contains 1 changes across 1 issues, since 2023-10-31 20:37:09 (timezone: Singapore)

Improve test code coverage of core components #12588

@cedricongjh modified this issue on 2023-11-01 22:27:15

Description of feature/enhancement
The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)

Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested

Submit the PR, link it to this issue by starting the description with "Part of #12588"

Components:

Component Assignee Codecov PR

AddingQuestionPanelComponent ＠sdpunit link -

CommentEditFormComponent ＠HarryLu33 link TEAMMATES/teammates#12604

CommentRowComponent ＠ThomasGreen123 link TEAMMATES/teammates#12612

CommentTableComponent ＠u7505884 link -

CommentTableModalComponent ＠kenneySiu link TEAMMATES/teammates#12609

CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe ＠cedricongjh link1, link2, link3, link4 TEAMMATES/teammates#12589

CopyCourseModalComponent ＠cedricongjh link TEAMMATES/teammates#12590

CopySessionModalComponent ＠Astrid641 link -

CourseEditFormComponent ＠lunoos link TEAMMATES/teammates#12597

DatepickerComponent ＠dlimyy link TEAMMATES/teammates#12592

DatePickerFormatter ＠dlimyy link TEAMMATES/teammates#12593

ErrorReportComponent ＠u7488099 link TEAMMATES/teammates#12610

ExtensionConfirmModalComponent ＠MatheuMa link TEAMMATES/teammates#12622

FeedbackPathPanelComponent ＠JYH11 link TEAMMATES/teammates#12613

LogsHistogramComponent ＠Miranda-lrx link -

LogsTableComponent ＠sdpunit link -

LogsDetails ＠nikkixiong link TEAMMATES/teammates#12618

LogsLine ＠090997 link -

RecipientTypeNamePipe ＠ThomasGreen123 link TEAMMATES/teammates#12626

SessionEditForm ＠kenneySiu link TEAMMATES/teammates#12627

github-actions · 2023-11-08T09:19:50Z

Digest Summary: 2023-11-08 17:19:49

... contains 1 changes across 1 issues, since 2023-11-01 23:21:06 (timezone: Singapore)

Improve test code coverage of core components #12588

@cedricongjh modified this issue on 2023-11-08 17:09:03

Description of feature/enhancement
The components in src/web/app/components are used throughout TEAMMATES, but some of them have poor test coverage. Let's improve the test coverage in these components:

Steps to contribute

Choose component(s) to work on in the table below, and comment on this issue to indicate that you'd like to contribute tests for the component(s)

Create a PR with tests for the component, check the codecov link to ensure that the functionality not covered are indeed tested

Submit the PR, link it to this issue by starting the description with "Part of #12588"

Components:

Component Assignee Codecov PR

AddingQuestionPanelComponent ＠sdpunit link -

CommentEditFormComponent ＠HarryLu33 link TEAMMATES/teammates#12604

CommentRowComponent ＠ThomasGreen123 link TEAMMATES/teammates#12612

CommentTableComponent ＠u7505884 link -

CommentTableModalComponent ＠kenneySiu link TEAMMATES/teammates#12609

CommentVisibilityControlNamePipe, CommentVisibilityTypeDescriptionPipe, CommentVisibilityTypeNamePipe, CommentVisibilityTypesJointNamePipe ＠cedricongjh link1, link2, link3, link4 TEAMMATES/teammates#12589

CopyCourseModalComponent ＠cedricongjh link TEAMMATES/teammates#12590

CopySessionModalComponent ＠Astrid641 link TEAMMATES/teammates#12616

CourseEditFormComponent ＠lunoos link TEAMMATES/teammates#12597

DatepickerComponent ＠dlimyy link TEAMMATES/teammates#12592

DatePickerFormatter ＠dlimyy link TEAMMATES/teammates#12593

ErrorReportComponent ＠u7488099 link TEAMMATES/teammates#12610

ExtensionConfirmModalComponent ＠MatheuMa link TEAMMATES/teammates#12622

FeedbackPathPanelComponent ＠JYH11 link TEAMMATES/teammates#12613

LogsHistogramComponent ＠Miranda-lrx link -

LogsTableComponent ＠sdpunit link -

LogsDetails ＠nikkixiong link TEAMMATES/teammates#12618

LogsLine ＠090997 link TEAMMATES/teammates#12628

RecipientTypeNamePipe ＠ThomasGreen123 link TEAMMATES/teammates#12626

SessionEditForm ＠kenneySiu link TEAMMATES/teammates#12627

github-actions · 2023-11-14T17:18:18Z

Digest Summary: 2023-11-15 01:18:17

... contains 1 changes across 1 issues, since 2023-11-08 17:19:50 (timezone: Singapore)

Create Unit Tests for Feedback*QuestionDetails classes #1501

@sardorjumamuratov created this comment on 2023-11-15 00:45:24

Hi there. Is this still available? I would like to work on it!

[teammates/TEAMMATES] Issues Digest #3

[teammates/TEAMMATES] Issues Digest #3

Comments

github-actions bot commented Jul 24, 2023 • edited Loading

github-actions bot commented Jul 24, 2023

Digest Summary: 2023-07-24 23:51:57

Instructor courses page: some items don't show spinners #10508

Instructor sending submission reminders: missing space between checkbox and label #12313

Refactoring of sortable tables #12329

Flickering questions when loading sessions results #12499

Nonspecific error messages on E2E tests #12513

V8.28.1 #12520

Save all comments when saving responses for all questions #12527

github-actions bot commented Jul 26, 2023

Digest Summary: 2023-07-26 20:38:29

Update tzdb version to 2023b or newer #12259

github-actions bot commented Jul 26, 2023

Digest Summary: 2023-07-27 05:16:52

Instructor view session results (course-wide): Add separate button to download results by question #12283

github-actions bot commented Jul 27, 2023

Digest Summary: 2023-07-27 17:19:11

Instructor view session results (course-wide): Add separate button to download results by question #12283

github-actions bot commented Jul 29, 2023

Digest Summary: 2023-07-29 22:18:23

Dark Theme #12529

github-actions bot commented Jul 30, 2023

Digest Summary: 2023-07-30 16:22:01

Header: unable to expand dropdown with keyboard commands #12530

Header: "Log Out" button cannot be tabbed over #12531

Instructor Home Page: Remind dropdown expands into the table #12532

Instructor Home Page: tabbing doesn't work for most buttons on the Course dropdown #12533

Panels Tab Expandability #12534

Instructor Course Page: "Show" group cannot be tabbed over #12535

Instructor Search Page: sorting affects sort icons for all tables #12536

github-actions bot commented Jul 30, 2023

Digest Summary: 2023-07-30 17:16:58

Instructor Search Page: sorting affects sort icons for all tables #12536

github-actions bot commented Jul 30, 2023

Digest Summary: 2023-07-30 19:15:04

Refactoring of sortable tables #12329

github-actions bot commented Jul 30, 2023

Digest Summary: 2023-07-31 00:23:52

Refactoring of sortable tables #12329

github-actions bot commented Jul 31, 2023

Digest Summary: 2023-07-31 17:20:28

Instructor sessions page: Empty deleted sessions table is not displayed #12538

github-actions bot commented Jul 31, 2023

Digest Summary: 2023-07-31 20:41:25

Instructor sessions page: Empty deleted sessions table is not displayed #12538

github-actions bot commented Jul 31, 2023

Digest Summary: 2023-07-31 23:22:22

Refactoring of sortable tables #12329

github-actions bot commented Aug 1, 2023

Digest Summary: 2023-08-01 16:24:11

Instructor Home Page: Remind dropdown expands into the table #12532

github-actions bot commented Aug 4, 2023

Digest Summary: 2023-08-04 18:23:08

Instructor sessions page: Empty deleted sessions table is not displayed #12538

github-actions bot commented Aug 4, 2023

Digest Summary: 2023-08-04 19:16:07

Instructor sessions page: Empty deleted sessions table is not displayed #12538

Cannot download results of session due to #12544

github-actions bot commented Aug 4, 2023

Digest Summary: 2023-08-04 20:36:45

Cannot download results of session due to #12544

github-actions bot commented Aug 4, 2023

Digest Summary: 2023-08-04 21:22:43

Cannot download results of session due to #12544

github-actions bot commented Aug 4, 2023

Digest Summary: 2023-08-04 22:20:45

Cannot download results of session due to #12544

github-actions bot commented Aug 5, 2023

Digest Summary: 2023-08-05 12:22:09

Cannot download results of session due to #12544

github-actions bot commented Aug 5, 2023

Digest Summary: 2023-08-05 13:19:50

Cannot download results of session due to #12544

github-actions bot commented Aug 5, 2023

Digest Summary: 2023-08-05 14:22:54

Cannot download results of session due to #12544

github-actions bot commented Jul 24, 2023 •

edited

Loading