Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The final report contains "Skipped" steps for tests, which were retested #1053

Open
ilya-corp opened this issue May 27, 2022 · 8 comments
Open

Comments

@ilya-corp
Copy link

Hello!
I have two passes of my tests: first - multithread (results into multi.json) and second - singlethread with retesting of failed scenarios (retest.json). During my second pass I generate SkipException for tests, which were passed at first pass.
After finishing of both passes, I perform report generation:

                            E2E-Cucumber                             false                             target                             target                             *.json                             true                             true                             true                             true

Finally my report contains identical number of executed steps in the columns Skipped and Passed (see screenshot).

My expectation:
Report must display execution time of every scenario and number of performed steps based on the following:

  1. for successful and failed tests use the most recent data
  2. for successful+skipped use data of successful
  3. for failed+skipped use data of failed

So, finally:
| Pass 1 | Pass 2 | Result | Use data of |
| Success | Skipped | Success | Pass 1 |
| Failed | Success | Success | Pass 2 |
| Skipped | Success | Success | Pass 2 |
| Failed | Failed | Failed | Pass 2 |

I don't need to see number of executed steps, performed at previous attempt, in the tests, which was retested. I need to see only number of retest steps.

Version of the plugin maven.cucumber.reporting: 5.7.0

@ilya-corp
Copy link
Author

report

@ilya-corp ilya-corp changed the title The final report have "skipped" status for tests, which were retested The final report contains "Skipped" steps for tests, which were retested May 27, 2022
@damianszczepanik
Copy link
Owner

Attach JSON file.
Are you talking about scenario or step which are executed for @given ?

@ilya-corp
Copy link
Author

ilya-corp commented May 30, 2022

I mentioned steps (Given, And, Then etc).
As you can see, for main part of features contains identical number of performed steps. For example, for the first line of the screenshot you can see 18 passed steps and 18 skipped steps. It's because all 18 steps were successfully performed during first pass AND during second pass all steps of this scenario were skipped. So I suggest to leave only 18 passed steps and 0 skipped.

The JSON file is huge and contains some business data, do you really need it?

@ilya-corp
Copy link
Author

ilya-corp commented Jun 6, 2022

I use both options

 <mergeFeaturesById>true</mergeFeaturesById>
 <mergeFeaturesWithRetest>true</mergeFeaturesWithRetest>

Is it a error to use them both?

@ilya-corp
Copy link
Author

I have tried, but without positive result. Please see my new screenshot
Cucumber-2
.

@ilya-corp
Copy link
Author

 <configuration>
                            <projectName>E2E-Cucumber</projectName>
                            <skip>false</skip>
                            <outputDirectory>target</outputDirectory>
                            <inputDirectory>target</inputDirectory>
                            <jsonFiles>*.json</jsonFiles>
                            <setSkippedAsNotFailing>true</setSkippedAsNotFailing>
                            <skipEmptyJSONFiles>true</skipEmptyJSONFiles>
                            <mergeFeaturesWithRetest>true</mergeFeaturesWithRetest>
                        </configuration>

@damianszczepanik
Copy link
Owner

I use both options

 <mergeFeaturesById>true</mergeFeaturesById>
 <mergeFeaturesWithRetest>true</mergeFeaturesWithRetest>

Is it a error to use them both?

Honestly I have no idea how to answer for that question as most of those features were developed by guys who need them. I don't :)
So my recommendation is to experiment and check...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants