Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for closing windows #100

Open
ryanzec opened this issue Jun 6, 2014 · 0 comments
Open

Added support for closing windows #100

ryanzec opened this issue Jun 6, 2014 · 0 comments

Comments

@ryanzec
Copy link
Contributor

ryanzec commented Jun 6, 2014

It seems like if a test opens a new tab and then more test continue, they can fail because of the opened tab. I added support to close the tab with the JSON Wire Protocol and after that, the test would pass (tried it 5 time with no problems).

We should add support for this to be able to combat this issue. The close() action will will close the current window and autmatically select the parent window.

Related issues:
dalekjs/dalek-internal-webdriver#9
dalekjs/dalek-driver-native#15

@ryanzec ryanzec self-assigned this Jun 6, 2014
ryanzec pushed a commit that referenced this issue Jun 10, 2014
asciidisco added a commit that referenced this issue Nov 28, 2014
# By Ryan Zec (2) and others
# Via Sebastian Golasch (5) and others
* 'master' of github.com:dalekjs/dalek:
  Update suite.js
  added .to.not.contain() helper
  update dependencies
  all devDependencies Up to date
  added close action (#100)
  fixed method descriptions
  fixed typo
  re-implemented PR with recommended changes
  change doku for setValue
  fix coffeescript 1.7 require

Conflicts:
	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants