Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC8410: Algorithm Identifiers for Ed25519, Ed448, X25519, and X448 for Use in the Internet X.509 Public Key Infrastructure #707

Open
stevefan1999-personal opened this issue Sep 25, 2024 · 2 comments

Comments

@stevefan1999-personal
Copy link

https://datatracker.ietf.org/doc/html/rfc8410

We can workaround this by using a wrapper that implements https://docs.rs/spki/latest/spki/trait.DynSignatureAlgorithmIdentifier.html...

@juliusl
Copy link
Contributor

juliusl commented Oct 3, 2024

I submitted a PR for ed25519-dalek;

However, one thing I noticed though is that after implementing DynSignatureAlgorithmIdentifier x509-cert still needs ed25519::Signature to implement SignatureBitStringEncoding in order to build certificates with SigningKey/VerifyingKey. I worked around this in my PR but I'm not sure if it's better to fix ed25519 first or to just fix the issue in this crate.

@juliusl
Copy link
Contributor

juliusl commented Oct 3, 2024

Realized that the x509 should've probably been a separate issue so I removed it from the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants