feat : Trait Reduce implemented for U256 and U512 on struct Scalar #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozbb
reviewed
Oct 24, 2024
|
|
||
| // Reduce trait | ||
|
|
||
| pub trait Reduce<T>{ |
There was a problem hiding this comment.
Why is this re-defined here? Isn't the point of the referenced issue that we should be implementing the Reduce trait from elliptic_curve?
There was a problem hiding this comment.
Also note we'll have another breaking release of elliptic-curve out soon, probably early 2025, so it would probably make sense to target these changes along with #676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation will help standardize scalar reduction across different elliptic curve libraries, addressing the inconsistency
closes #688