From 24b2c68c2ae5fdc5e1c4932f936470e5d827b6a7 Mon Sep 17 00:00:00 2001 From: Raphael Levin Date: Fri, 6 Oct 2023 18:02:47 +0200 Subject: [PATCH] fix typo and update formatting --- spec/samples/inline_trackers.js | 2 +- src/fetcher.js | 2 +- src/parser/vast_parser.js | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/spec/samples/inline_trackers.js b/spec/samples/inline_trackers.js index bb674431..d88cbf4a 100644 --- a/spec/samples/inline_trackers.js +++ b/spec/samples/inline_trackers.js @@ -234,7 +234,7 @@ export const inlineTrackersParsed = { 'https://www.iab.com/wp-content/uploads/2014/09/iab-tech-lab-6-644x290.png', htmlResource: '\n \n \n \n \n \n Document\n \n \n

titre

\n \n ', - iframeResource: 'liens vers html', + iframeResource: 'http://example.com/htmlresourcefile.html', nonlinearClickThroughURLTemplate: 'https://iabtechlab.com', nonlinearClickTrackingURLTemplates: [ { diff --git a/src/fetcher.js b/src/fetcher.js index 0f8b86d9..1dd0f449 100644 --- a/src/fetcher.js +++ b/src/fetcher.js @@ -63,7 +63,7 @@ export class Fetcher { /** * Fetches a VAST document for the given url. * Returns a Promise which resolves,rejects according to the result of the request. - * @param {String} url - The url to request the VAST document. + * @param {String} url - The url to request the VAST document. * @param {Number} wrapperDepth - How many times the current url has been wrapped. * @param {String} previousUrl - Url of the previous VAST. * @param {Object} wrapperAd - Previously parsed ad node (Wrapper) related to this fetching. diff --git a/src/parser/vast_parser.js b/src/parser/vast_parser.js index 3ce74c9e..b8ce6dfa 100644 --- a/src/parser/vast_parser.js +++ b/src/parser/vast_parser.js @@ -359,9 +359,7 @@ export class VASTParser extends EventEmitter { return new Promise((resolve) => { // Going one level deeper in the wrapper chain wrapperDepth++; - // We already have a resolved VAST ad, no need to resolve wrapper - if (!ad.nextWrapperURL) { delete ad.nextWrapperURL; return resolve(ad);