Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: toggling "Show/Hide pinned posts" doesn't work #1633

Open
1 task done
sshanzel opened this issue Dec 3, 2024 · 1 comment
Open
1 task done

🐛 BUG: toggling "Show/Hide pinned posts" doesn't work #1633

sshanzel opened this issue Dec 3, 2024 · 1 comment

Comments

@sshanzel
Copy link
Member

sshanzel commented Dec 3, 2024

What went wrong? 🤔

Clicking the button to either hide or show pinned posts, it won't do anything. The label changes but the content from the Squad page remains the same.

Expected Behavior

It should either show or hide the posts depending on the current state.

Steps to Reproduce Issue

1. Go to https://app.daily.dev/squads/ai
2. Click on Show/Hide pinned post
3. The label on the button changes
4. The feed posts remain the same

Solution Proposed

We use the currentMember?.flags?.collapsePinnedPosts property to check whether the posts should be displayed. We did some optimizations where we reduced the props we request from GraphQL and this property could now be missing. After adding it back on the request it should return back to normal.

If I'm not mistaken, the feed graphql request query can be found in /graphql/feed file.

Screenshots

No response

Environment

No response

Browsers

No response

OS

No response

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@itsalam
Copy link

itsalam commented Dec 4, 2024

Hey @sshanzel, wanted to try working on this using the provided GitPod for development but it seems to also be running into issues with the graphQL queries.

Could you take a look at the graphql's base URL in shared config file and confirm it should be from "/api"? This seems to cause an issue as the graphql-request Client requires a full URL which doesn't happen in GitPod.

It seems that the changes in the next config doesn't apply to the requests from the graphql-request client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants