Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: issue on mobile UI some text overflow while the user comments for better understanding screenshot attached. #1549

Open
1 task done
faiq157 opened this issue Oct 29, 2024 · 10 comments

Comments

@faiq157
Copy link

faiq157 commented Oct 29, 2024

What went wrong? 🤔

1000187636

Expected Behavior

No response

Steps to Reproduce Issue

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See the error

Solution Proposed

No response

Screenshots

![DESCRIPTION](LINK.png)

Environment

No response

Browsers

No response

OS

No response

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@Junaid-Shaukat
Copy link

I want to work on it, can you assign it to me.

@idoshamun
Copy link
Member

Hi @faiq157,

Thanks for reporting. We will look into it.

@sshanzel
Copy link
Member

@Junaid-Shaukat feel free to take a look! There should be a component along the lines of CommentActionButtons - the issue could be coming from there.

@Junaid-Shaukat
Copy link

@Junaid-Shaukat feel free to take a look! There should be a component along the lines of CommentActionButtons - the issue could be coming from there.

@sshanzel Thanks for assigning this issue to me. I have started working on it. I'll update you soon.

@RamvigneshA
Copy link

@sshanzel Can i fix this bug , can you assign me.?

@sshanzel
Copy link
Member

@RamvigneshA feel free to check it, as @Junaid-Shaukat might have gotten busy with personal responsibilities, and that's okay.

@Junaid-Shaukat
Copy link

@RamvigneshA do check it, I am little busy and @sshanzel can you please clear to me that in which repo i can find that app for mobile that i can clone it and setup locally. I try to find but the code is not in one repo?

@RamvigneshA
Copy link

@Junaid-Shaukat type this link to reach the required repo code to solve this issue..
https://github.com/dailydotdev > apps repo > search for(1) CommentActionButtons react component file ,(2) button.tsx and (3)common.ts file to solve the issue.
i'm occupied for 2 days so you try buddy..
i will try after 2 days..
happy coding..

@RamvigneshA
Copy link

RamvigneshA commented Nov 28, 2024

@Junaid-Shaukat If you feel difficulties to find any repo in your future contributions, you should try to find the repo by reaching the pull request tab ,there you can see the people merge and pull request. there you can find the repo codebase.
small trick. :)

@sshanzel
Copy link
Member

sshanzel commented Dec 4, 2024

@RamvigneshA do check it, I am little busy and @sshanzel can you please clear to me that in which repo i can find that app for mobile that i can clone it and setup locally. I try to find but the code is not in one repo?

As @RamvigneshA wonderfully suggested, kindly check the apps repo, and the CommentActionButtons should be the place to make the changes. However, I think we should just apply an ellipsis on the "2 upvotes" text in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants