-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: spike remote media player #3
Open
janyk
wants to merge
1
commit into
daily-co:main
Choose a base branch
from
Serena-App:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
DailyPlayground/ios/DailyPlayground.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>IDEDidComputeMac32BitWarning</key> | ||
<true/> | ||
</dict> | ||
</plist> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,45 @@ | ||
const newRoomEndpoint = | ||
'https://f433xwze36.execute-api.us-west-2.amazonaws.com/default/dailyRnDemoNewCall'; | ||
const DAILY_TOKEN = 'somedailytoken'; | ||
interface IDailyResponse { | ||
id: string; | ||
name: string; | ||
api_created: boolean; | ||
privacy: string; | ||
url: string; | ||
created_at: string; | ||
config?: { | ||
exp?: number; | ||
start_audio_off?: boolean; | ||
start_video_off?: boolean; | ||
max_participants?: boolean; | ||
}; | ||
} | ||
async function createRoom() { | ||
// generate a random room name | ||
const roomName = 'daily-room-' + Math.floor(Math.random() * 999999); | ||
try { | ||
const response: Response = await fetch('https://api.daily.co/v1/rooms/', { | ||
method: 'POST', | ||
...getApiConfig(), | ||
body: JSON.stringify({ | ||
name: roomName, | ||
}), | ||
}); | ||
const data = await response.json(); | ||
console.log('data', data.url); | ||
} catch (error: unknown) { | ||
console.error(error); | ||
} | ||
|
||
/** | ||
* Create a short-lived room for demo purposes. | ||
* | ||
* IMPORTANT: this is purely a "demo-only" API, and *not* how we recommend | ||
* you create rooms in real production code. In your code, we recommend that you: | ||
* - Create rooms by invoking the Daily.co REST API from your own backend server | ||
* (or from the Daily.co dashboard if you're OK with creating rooms manually). | ||
* - Pass an "exp" (expiration) parameter to the Daily.co REST endpoint so you | ||
* don't end up with a huge number of live rooms. | ||
* | ||
* See https://docs.daily.co/reference#create-room for more information on how | ||
* to use the Daily.co REST API to create rooms. | ||
*/ | ||
async function createRoom(): Promise<{ url: string }> { | ||
let response = await fetch(newRoomEndpoint); | ||
return await response.json(); | ||
return undefined; | ||
} | ||
|
||
// Comment out the above and uncomment the below, using your own URL | ||
// return { url: "https://your-domain.daily.co/hello" }; | ||
function getApiConfig() { | ||
return { | ||
headers: { | ||
Authorization: `Bearer ${DAILY_TOKEN}`, | ||
'Content-Type': 'application/json', | ||
}, | ||
}; | ||
} | ||
|
||
export default { createRoom }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues happen with and without this, not sure if we need to do this, playback works without