fix: Apply temporary logic to apply missing fonts in the current excalidraw package #56
Conversation
|
Thanks for the investigation! Yeah, let's wait for the upstream fix. Meanwhile, I manually deployed https://dai-shi.github.io/excalidraw-animate/ from this branch. |
Sounds good. Feel free to close this PR if it's no longer needed then |
|
Let's keep it open. |
|
@dai-shi Here is the updated version of this branch! I have changed;
Gif
|
|
Feel free to send more PRs to improve things. |
|
Hi, Does this PR only fix the rendering issue on the web? If I choose to 'export to SVG', will I get
It seems similar to a web rendering bug before the PR submission, here I used the Excalidraw file shared in issue#55 |
|
probably so? @kei95 |
|
@dangehub That's right svg export is out of the scope for this PR |
I fixed the bug where other fonts didn't work when exporting to SVG. Additionally, my branch now supports third-party fonts (for compatibility with obsidian-excalidraw), maybe I can pr ?
|
|
yeah, please open a pr. |
Issue
#55
What the change is about
It turned out that the
@excalidraw/excalidrawpackage is way behind the released app version, hence the issue as the package doesn't know any added fonts that are present in the app. This PR adds fonts and logic to apply missing fonts and adopt newly added fonts so that this app can display any fonts in the current version of the excalidraw.@dai-shi This is a bit of an ugly patch-up to manually apply missing fonts in the package until we get the update from Excalidraw. It at least does its job to adopt the fonts but I'd say it's up to you to have this change meanwhile or wait for their update without it!
Screenshot / Gif
Base canvas in Excalidraw
Imported svg
