From 6f60763527cb85dbaa08c677a58b126967aece51 Mon Sep 17 00:00:00 2001 From: JamieDeMaria Date: Tue, 12 Nov 2024 10:20:13 -0500 Subject: [PATCH] small --- .../dagster/dagster/_core/execution/asset_backfill.py | 2 +- .../dagster/dagster_tests/daemon_tests/test_backfill.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/python_modules/dagster/dagster/_core/execution/asset_backfill.py b/python_modules/dagster/dagster/_core/execution/asset_backfill.py index a3c957bb82c76..697b3e920f00f 100644 --- a/python_modules/dagster/dagster/_core/execution/asset_backfill.py +++ b/python_modules/dagster/dagster/_core/execution/asset_backfill.py @@ -954,7 +954,7 @@ def backfill_is_complete( if ( # Condition 1 - all asset partitions in the target subset have a materialization state backfill_data.all_targeted_partitions_have_materialization_status() - # Condtition 2 - there are no in progress runs for the backfill + # Condition 2 - there are no in progress runs for the backfill and len( instance.get_run_ids( filters=RunsFilter( diff --git a/python_modules/dagster/dagster_tests/daemon_tests/test_backfill.py b/python_modules/dagster/dagster_tests/daemon_tests/test_backfill.py index 7002307fc4662..7b659ef0c6442 100644 --- a/python_modules/dagster/dagster_tests/daemon_tests/test_backfill.py +++ b/python_modules/dagster/dagster_tests/daemon_tests/test_backfill.py @@ -2868,11 +2868,12 @@ def test_asset_backfill_not_complete_until_retries_complete( list(execute_backfill_iteration(workspace_context, get_default_daemon_logger("BackfillDaemon"))) backfill = instance.get_backfill(backfill_id) assert backfill + assert backfill.asset_backfill_data assert backfill.asset_backfill_data.all_targeted_partitions_have_materialization_status() assert backfill.status == BulkActionStatus.REQUESTED # manually mark the run as successful to show that the backfill will be marked as complete - # since there are no in prgress runs + # since there are no in progress runs instance.handle_new_event( EventLogEntry( error_info=None, @@ -2943,6 +2944,7 @@ def test_asset_backfill_not_complete_if_automatic_retry_could_happen( list(execute_backfill_iteration(workspace_context, get_default_daemon_logger("BackfillDaemon"))) backfill = instance.get_backfill(backfill_id) assert backfill + assert backfill.asset_backfill_data assert backfill.asset_backfill_data.all_targeted_partitions_have_materialization_status() assert backfill.status == BulkActionStatus.REQUESTED