From 21ae854bfd47bc23c40561ab02c76e41fe337f8d Mon Sep 17 00:00:00 2001 From: prha Date: Fri, 3 Jan 2025 09:25:33 -0800 Subject: [PATCH] fix error message, descriptions --- .../dagster/dagster/_core/definitions/op_definition.py | 5 ++--- .../dagster/dagster/_core/snap/execution_plan_snapshot.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/python_modules/dagster/dagster/_core/definitions/op_definition.py b/python_modules/dagster/dagster/_core/definitions/op_definition.py index c811fe5b958c8..2e853b558091c 100644 --- a/python_modules/dagster/dagster/_core/definitions/op_definition.py +++ b/python_modules/dagster/dagster/_core/definitions/op_definition.py @@ -91,8 +91,7 @@ class OpDefinition(NodeDefinition, IHasInternalInit): code_version (Optional[str]): (Experimental) Version of the code encapsulated by the op. If set, this is used as a default code version for all outputs. retry_policy (Optional[RetryPolicy]): The retry policy for this op. - pool (Optional[str]): A string that identifies the concurrency limit group that governs - this op's execution. + pool (Optional[str]): A string that identifies the pool that governs this op's execution. Examples: @@ -613,7 +612,7 @@ def _validate_pool(pool, tags): tag_concurrency_key = tags.get(GLOBAL_CONCURRENCY_TAG) if pool and tag_concurrency_key and pool != tag_concurrency_key: raise DagsterInvalidDefinitionError( - f'Concurrency group "{pool}" that conflicts with the concurrency key tag "{tag_concurrency_key}".' + f'Pool "{pool}" conflicts with the concurrency key tag "{tag_concurrency_key}".' ) if pool: diff --git a/python_modules/dagster/dagster/_core/snap/execution_plan_snapshot.py b/python_modules/dagster/dagster/_core/snap/execution_plan_snapshot.py index 93205047266d9..b69fb4c5eca18 100644 --- a/python_modules/dagster/dagster/_core/snap/execution_plan_snapshot.py +++ b/python_modules/dagster/dagster/_core/snap/execution_plan_snapshot.py @@ -177,7 +177,7 @@ def __new__( ), tags=check.opt_nullable_mapping_param(tags, "tags", key_type=str, value_type=str), step_handle=check.opt_inst_param(step_handle, "step_handle", StepHandleTypes), - # stores the concurrency group arg as separate from the concurrency_key property since the + # stores the pool arg as separate from the concurrency_key property since the # snapshot may have been generated before concurrency_key was added as a separate # argument pool=check.opt_str_param(pool, "pool"),