-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken links #205
Comments
(/search - when clicking on a user on the list, it routes to a /profile/username, must be /[username]. Can we make this a modal instead?) I think it was made that way to optimize SEO when a URL or username is shared on social media. I agree with making it a modal, but perhaps we could use shallow routing so that SEO still works? |
I think that's a good idea. Do you already know how to implement it?
|
Shallow route would be good there too, clicking the link pushes to the page state and render a modal. |
I already fixed the broken links indicated in the issue description. Except for this modal thing, if you could implement it that'd be great, I already started the PR for this issue |
It's a different issue, the #207 links are not broken and is working, but the links on this issue literally doesn't |
Ahh i see it's referring to the |
/search
- when clicking on a user on the list, it routes to a/profile/username
, must be/[username]
. Can we make this a modal instead?/[username]
- themailto:
link does not have proper name it's just "@" and there's no prompt or any visual indicator what it will do. It opens up email which might hurt UX.The text was updated successfully, but these errors were encountered: