Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links #205

Open
1 of 2 tasks
DDuran19 opened this issue Jun 24, 2024 · 7 comments · May be fixed by #209
Open
1 of 2 tasks

Broken links #205

DDuran19 opened this issue Jun 24, 2024 · 7 comments · May be fixed by #209
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@DDuran19
Copy link
Contributor

DDuran19 commented Jun 24, 2024

  • /search - when clicking on a user on the list, it routes to a /profile/username, must be /[username]. Can we make this a modal instead?
  • /[username] - the mailto: link does not have proper name it's just "@" and there's no prompt or any visual indicator what it will do. It opens up email which might hurt UX.
    image
@DDuran19 DDuran19 added bug Something isn't working enhancement New feature or request labels Jun 24, 2024
@DDuran19 DDuran19 self-assigned this Jun 24, 2024
DDuran19 added a commit that referenced this issue Jun 25, 2024
@DDuran19 DDuran19 linked a pull request Jun 25, 2024 that will close this issue
@devpapi0891
Copy link
Contributor

(/search - when clicking on a user on the list, it routes to a /profile/username, must be /[username]. Can we make this a modal instead?)

I think it was made that way to optimize SEO when a URL or username is shared on social media. I agree with making it a modal, but perhaps we could use shallow routing so that SEO still works?

@DDuran19
Copy link
Contributor Author

I think that's a good idea. Do you already know how to implement it?

I think it was made that way to optimize SEO when a URL or username is shared on social media. I agree with making it a modal, but perhaps we could use shallow routing so that SEO still works?

@directormac
Copy link
Contributor

Shallow route would be good there too, clicking the link pushes to the page state and render a modal.

@DDuran19
Copy link
Contributor Author

I already fixed the broken links indicated in the issue description. Except for this modal thing, if you could implement it that'd be great, I already started the PR for this issue

@directormac
Copy link
Contributor

The links from #207 ? I asked @os-hi about it i think he prefer those links to be on the #events or something as he was doing the part on the smooth scroll afair.

@DDuran19
Copy link
Contributor Author

It's a different issue, the #207 links are not broken and is working, but the links on this issue literally doesn't

@directormac
Copy link
Contributor

Ahh i see it's referring to the /search i thought this was from the /team page. I thought you fixed this issue when on your last pr, because before the /search page just had a dummy functionality i think it was #204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants