From 776f9e5b2dd4e4f33ec5d81cd84903fd45812391 Mon Sep 17 00:00:00 2001 From: "Damon P. Cortesi" Date: Sun, 2 Aug 2020 22:33:40 -0700 Subject: [PATCH] Minor todo comment --- src/metabase/driver/athena.clj | 1 + 1 file changed, 1 insertion(+) diff --git a/src/metabase/driver/athena.clj b/src/metabase/driver/athena.clj index 2702c17..7bbb74c 100644 --- a/src/metabase/driver/athena.clj +++ b/src/metabase/driver/athena.clj @@ -245,6 +245,7 @@ ;; Required because we're calling our own custom private get-tables method to support Athena (defn- fast-active-tables [driver, ^DatabaseMetaData metadata, & [db-name-or-nil]] + ;; TODO: Catch errors here so a single exception doesn't fail the entire schema (with-open [rs (.getSchemas metadata)] (let [all-schemas (set (map :table_schem (jdbc/metadata-result rs))) schemas (set/difference all-schemas (sql-jdbc.sync/excluded-schemas driver))]