From fc22db670b6b7d4f85e94cac9f2c6786d7efa4bb Mon Sep 17 00:00:00 2001 From: Al Power Date: Thu, 25 Feb 2021 18:03:54 +0000 Subject: [PATCH 1/3] Add override option for checkbox radius --- src/less/overrides.less | 2 +- src/less/variables.less | 1 + src/ts/components/forms/form-group.examples.md | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/less/overrides.less b/src/less/overrides.less index bde3db559..66edd05b1 100644 --- a/src/less/overrides.less +++ b/src/less/overrides.less @@ -186,7 +186,7 @@ input[type='radio'] { } input[type='checkbox'] { - border-radius: @border-radius-base * 2; + border-radius: @checkbox-border-radius-base; &:checked { background-color: @checkbox-active-background; diff --git a/src/less/variables.less b/src/less/variables.less index 196a47b8d..bc60350a7 100644 --- a/src/less/variables.less +++ b/src/less/variables.less @@ -186,6 +186,7 @@ @checkbox-icon-background: @checkbox-background; @checkbox-icon-border: 2px solid @checkbox-icon-background; @checkbox-shadow: inset 0 1px 1.5px 0 rgba(0, 0, 0, 0.1); +@checkbox-border-radius-base: @border-radius-base * 2; @pagination-button-color: @grey-dark; @pagination-button-background: @grey-lighter; diff --git a/src/ts/components/forms/form-group.examples.md b/src/ts/components/forms/form-group.examples.md index c7f2da7d2..799c461c2 100644 --- a/src/ts/components/forms/form-group.examples.md +++ b/src/ts/components/forms/form-group.examples.md @@ -75,4 +75,5 @@ @checkbox-icon-background: @checkbox-background; @checkbox-icon-border: 2px solid @checkbox-icon-background; @checkbox-shadow: inset 0 1px 1.5px 0 rgba(0, 0, 0, 0.1); +@checkbox-border-radius-base: @border-radius-base * 2; ``` From c7f27b7a48966d35730aa14155220e9da9fae851 Mon Sep 17 00:00:00 2001 From: Al Power Date: Fri, 26 Feb 2021 13:40:43 +0000 Subject: [PATCH 2/3] Remove base reference. Apply suggestions from code review Co-authored-by: Jake 'Sid' Smith --- src/less/overrides.less | 2 +- src/less/variables.less | 2 +- src/ts/components/forms/form-group.examples.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/less/overrides.less b/src/less/overrides.less index 66edd05b1..de6d98573 100644 --- a/src/less/overrides.less +++ b/src/less/overrides.less @@ -186,7 +186,7 @@ input[type='radio'] { } input[type='checkbox'] { - border-radius: @checkbox-border-radius-base; + border-radius: @checkbox-border-radius; &:checked { background-color: @checkbox-active-background; diff --git a/src/less/variables.less b/src/less/variables.less index bc60350a7..21a2f1b01 100644 --- a/src/less/variables.less +++ b/src/less/variables.less @@ -186,7 +186,7 @@ @checkbox-icon-background: @checkbox-background; @checkbox-icon-border: 2px solid @checkbox-icon-background; @checkbox-shadow: inset 0 1px 1.5px 0 rgba(0, 0, 0, 0.1); -@checkbox-border-radius-base: @border-radius-base * 2; +@checkbox-border-radius: @border-radius-base * 2; @pagination-button-color: @grey-dark; @pagination-button-background: @grey-lighter; diff --git a/src/ts/components/forms/form-group.examples.md b/src/ts/components/forms/form-group.examples.md index 799c461c2..c9a221d67 100644 --- a/src/ts/components/forms/form-group.examples.md +++ b/src/ts/components/forms/form-group.examples.md @@ -75,5 +75,5 @@ @checkbox-icon-background: @checkbox-background; @checkbox-icon-border: 2px solid @checkbox-icon-background; @checkbox-shadow: inset 0 1px 1.5px 0 rgba(0, 0, 0, 0.1); -@checkbox-border-radius-base: @border-radius-base * 2; +@checkbox-border-radius: @border-radius-base * 2; ``` From 64e87081a68545636b4bf04f88005fffbe492ed2 Mon Sep 17 00:00:00 2001 From: Al Power Date: Tue, 2 Mar 2021 17:53:00 +0000 Subject: [PATCH 3/3] 0.12.3 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6239db01e..def4509f2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "@dabapps/roe", - "version": "0.12.2", + "version": "0.12.3", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index ac84d0603..87db3708f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@dabapps/roe", - "version": "0.12.2", + "version": "0.12.3", "description": "A collection of React components, styles, mixins, and atomic CSS classes to aid with the development of web applications.", "main": "dist/js/index.js", "types": "dist/js/index.d.ts",