Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output current route (VIRTUAL_HOST) when starting a routable process #26

Open
JakeSidSmith opened this issue Feb 12, 2020 · 3 comments
Open

Comments

@JakeSidSmith
Copy link
Contributor

It'd be nice if this were output in the terminal, as currently it only states the default http://127.0.0.1:8080/, this way users can click-through to the app they're running.

@RealOrangeOne
Copy link
Contributor

Making it print the current state of the router would be simple enough, but what does it provide? If the user starts their project then the router, the list is out of date. Starting/restarting projects after the router has started also leads to an out of date list.

Printing the assigned route when a project starts (ie crab web) might be more useful and make going to a project easier?

@JakeSidSmith
Copy link
Contributor Author

JakeSidSmith commented Feb 12, 2020

Is the router not project specific? If not, I guess web would work fine.

@RealOrangeOne
Copy link
Contributor

Correct, There's 1 crab router, which handles routing traffic from the given port to the specific project.

A process is routable if it's got a $VIRTUAL_HOST and has been allocated a port when it's executed. crab could print the allocated $VIRTUAL_HOST in that situation, which should be simple enough. The log message would need to be clearly not a part of the underlying application, which may be tricky, but not impossible.

@RealOrangeOne RealOrangeOne changed the title Output current route (VIRTUAL_HOST) when starting the router Output current route (VIRTUAL_HOST) when starting a routable process Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants