Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGuard hard-wires rules specifically for this test domain, and it would be best to take the valid subset of the feedback into account #127

Open
thestinger opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@thestinger
Copy link

https://github.com/AdguardTeam/AdguardFilters/blob/ad7ba2570a953157c09eb8aed0d1fbac7cf03d44/SpywareFilter/sections/specific.txt#L4168-L4200

As an example, this complaint of theirs could be fixed:

! Google Analytics admin panel. We're blocking what's required on this web site, but more granuralry (i.e. `/collect` location). Unfortunately, this test check for the whole domain blocking, hence here's a rule
||analytics.google.com^$domain=d3ward.github.io

This is simply cheating at the test because they don't want to block something breaking sites:

! Blocking of this domain may break Yahoo apps
||log.fc.yahoo.com^$domain=d3ward.github.io

My suggestion is to go through AdGuard's list, fix all of the valid issues they've complained about and then create an organization to move this repository to where it can work properly again once the valid issues are fixed. For domains/URLs that are actually used for ads/tracking which are not being blocked to avoid breaking sites, that seems perfectly fine. The ad blocker is simply making a trade-off and not showing as 100% is fine.

The current status quo is that the test essentially doesn't work, and it makes ad blockers which are not hard-wiring blocking for the test look worse than they should compared to ones that are.

@thestinger thestinger added the bug Something isn't working label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants