-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional angle radius parameter in curbeBezier curveStep
curves
#209
Comments
roipoussiere
changed the title
add curbeBezier curves
add optional angle radius parameter in curbeBezier Jul 9, 2023
curveStep
curves
Nice! Note that you need the difference in x and the difference in y to be greater than twice the radius—the spec should also describe what to do when it's smaller. |
Good point! I edited the issue. |
We'll need to specify all the cases :) pseudo code:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following #177, as suggested in #177 (comment), it could be useful to have a curve similar to
curveStep
but with smooth angles:An important note is that the curve angle should be identical whatever its length. This way we don't see curves duplication on nodes with many child of various link length:
Those curves could be namedcurbeBezierX
andcurbeBezierY
as suggested in this example.In fact, I think those curves could be included in
curveStep
, by adding an extra optional parameter allowing to define the angle radius, which is 0 by default.This will also allow some customization. This is for instance large angle (ie
curveStep(15)
) and small angle (iecurveStep(5)
) stepCurves, respectively:Some other visuals to get the idea:
curveStep(10)
curveStepBefore(10)
curveStepAfter(10)
Edit: as pointed out by @Fil, the curve horizontal and vertical distance might be lower than twice the angle radius. In that case the radius remains the same, but angles stops before 90° in order to share the same tangential line. Example with several curves formed with
curveStep(20)
, tangential line in red:The text was updated successfully, but these errors were encountered: