Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary prefixes #33

Open
mueslo opened this issue Dec 4, 2016 · 7 comments
Open

Binary prefixes #33

mueslo opened this issue Dec 4, 2016 · 7 comments

Comments

@mueslo
Copy link

mueslo commented Dec 4, 2016 •
edited
Loading

When visualising information, it would be quite useful to have the option of not just SI prefixes but also IEC binary prefixes, i.e. 1024 == Ki, 1048675 == Mi, etc.
@mueslo mueslo changed the title Binary prefix Binary prefixes Dec 4, 2016
@mbostock
Copy link
Member

mbostock commented Dec 4, 2016

Sounds like a reasonable suggestion. I have no immediate plans to implement this but would be willing to review a pull request that implements it.

nicksrandall added a commit to nicksrandall/d3-format that referenced this issue Feb 28, 2017
@nicksrandall
Allow SI prefixes to be set in locale.
b71f7cd 
This could serve as an escape hatch for somebody who wanted to support custom SI prefixes. This could be used to solve d3#33 (binary prefixes) or it could be used to support something custom like American english numbers (1,000,000,000 => 1B [billion] instead of 1G [giga]).
@nicksrandall nicksrandall mentioned this issue Feb 28, 2017
Closed
runarberg pushed a commit to runarberg/d3-format that referenced this issue May 6, 2019
Implement binary prefixes
eebecf0 
Closes: d3#33
This was referenced May 6, 2019
Closed
Open
runarberg pushed a commit to runarberg/d3-format that referenced this issue Jul 25, 2019
Implement binary prefixes
e5f914e 
Closes: d3#33
runarberg pushed a commit to runarberg/d3-format that referenced this issue Sep 2, 2019
Implement binary prefixes
4e982f2 
Closes: d3#33
runarberg pushed a commit to runarberg/d3-format that referenced this issue Mar 28, 2020
Implement binary prefixes
1dfc9ad 
Closes: d3#33
Fil pushed a commit that referenced this issue Jul 7, 2020
Implement binary prefixes
88f58ca 
Closes: #33
runarberg pushed a commit to runarberg/d3-format that referenced this issue Nov 11, 2020
Implement binary prefixes
e45a21e 
Closes: d3#33
runarberg pushed a commit to runarberg/d3-format that referenced this issue Nov 11, 2020
Implement binary prefixes
39fe3cb 
Closes: d3#33
@Fil
Copy link
Member

Fil commented Aug 23, 2023

#70 is a good option (needs to be rebased on main to be reopened).

runarberg pushed a commit to runarberg/d3-format that referenced this issue Aug 23, 2023
@runarberg
Implement binary prefixes
015f600 
Closes: d3#33
runarberg pushed a commit to runarberg/d3-format that referenced this issue Aug 23, 2023
@runarberg
Implement binary prefixes
3f2383d 
Closes: d3#33
@runarberg
Copy link

@Fil I rebased #70 on top of main and ran a couple of macros on the tests to keep them up to date. Let me know if there is anything else you need 😉

@grotlue
Copy link

grotlue commented Sep 29, 2023

Hello again👋
Is there any chance that #70 is being merged?

@Fil
Copy link
Member

Fil commented Sep 29, 2023

#70 lgtm

@grotlue
Copy link

grotlue commented Oct 13, 2023

Great! Is it possible to merge it to d3-format main?

@ldayananda
Copy link

Since it seems based on this comment that the IEC prefixes got stalled due to the currency changes -- would it be possible to extract the IEC changes to the main project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement binary prefixes runarberg/d3-format
6 participants
@Fil @mbostock @mueslo @grotlue @ldayananda @runarberg