Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genes are slow to expand #250

Open
maxkfranz opened this issue Feb 26, 2024 · 3 comments
Open

Genes are slow to expand #250

maxkfranz opened this issue Feb 26, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@maxkfranz
Copy link
Member

maxkfranz commented Feb 26, 2024

Describe the bug
A clear and concise description of what the bug is.

It's slow to expand a gene in the side bar.

A related but distinct issue:

To Reproduce
Steps to reproduce the behavior:

  1. Go to enrichmentmap.org
  2. Click on the demo
  3. Expand a gene
  4. It's not instant. It's like it's loading from the network. It's super slow if you're clicking one after another.

Expected behavior
A clear and concise description of what you expected to happen.

The genes should be fast to expand. The user shouldn't be slowed down.

Screenshots
If applicable, add screenshots to help explain your problem.

Screen.Recording.2024-02-26.at.11.27.37.mov
@maxkfranz maxkfranz added the bug Something isn't working label Feb 26, 2024
@mikekucera
Copy link
Contributor

mikekucera commented Feb 26, 2024

The caching was to prevent the gene panel from going to the server to get the list of genes. Expanding an individual gene is a different story. I think it has to contact an external service to get the gene description.

@chrtannus
Copy link
Member

That's exactly what Mike said. The gene details are cached in memory (actualy, it's just a controller property, I think).

@maxkfranz
Copy link
Member Author

OK, then this is a separate issue. This isn't about the initial loading of the gene panel, it's about expanding an entry in the list. I'll update the description.

@maxkfranz maxkfranz changed the title Is prod up-to-date re. gene caching? Genes are slow to expand Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants