Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected node label hard to read #225

Open
maxkfranz opened this issue Jan 12, 2024 · 2 comments
Open

Selected node label hard to read #225

maxkfranz opened this issue Jan 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@maxkfranz
Copy link
Member

maxkfranz commented Jan 12, 2024

Describe the bug
A clear and concise description of what the bug is.

It's hard to read the selected node label when it's crowded.

To Reproduce
Steps to reproduce the behavior:

  1. Expand a bubble.
  2. Click a node in the bubble.
  3. Can you read its label? Usually, I can't unless I drag the node out.

Expected behavior
A clear and concise description of what you expected to happen.

  • The selected node should be on top.
  • The selected node should be black and its label outline should be black.
  • When expanding a bubble, it should apply a grid layout to the children so that they don't overlap. We can fade out the other nodes, outside of the bubble, kind of like the Wine and Cheese app.

Screenshots

Screenshot 2024-01-12 at 09 07 38
@maxkfranz maxkfranz added the bug Something isn't working label Jan 12, 2024
@mikekucera
Copy link
Contributor

We discussed using a grid layout when the cluster is expanded. We could also fade the rest of the network when a cluster is selected.

@chrtannus chrtannus self-assigned this Feb 20, 2024
chrtannus added a commit that referenced this issue Feb 20, 2024
chrtannus added a commit that referenced this issue Feb 20, 2024
@chrtannus
Copy link
Member

Indeed, the label is more legible when the selected node is on top and the label outline has the same dark color as the node border:

BEFORE:
blue-label-outline
AFTER:
black-label-outline

Of course, this is only true if the adjacent/overlapping nodes are not selected as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants