Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual license as LGPL for Tiki #333

Closed
jasonmunro opened this issue Mar 27, 2019 · 11 comments
Closed

Dual license as LGPL for Tiki #333

jasonmunro opened this issue Mar 27, 2019 · 11 comments
Assignees
Labels
docs documentation related enhancement suggest an improvement

Comments

@jasonmunro
Copy link
Member

Add LGPL license support for easier Tiki integration (https://tiki.org/HomePage)

@jasonmunro jasonmunro added enhancement suggest an improvement docs documentation related labels Mar 27, 2019
@jasonmunro jasonmunro self-assigned this Mar 27, 2019
@marclaporte
Copy link
Member

Thanks Jason!

So I looked at https://github.com/jasonmunro/cypht/blob/master/composer.json and https://packagist.org/packages/html2text/html2text would need an adjustment. Do you see any others?

FYI to the Cypht community, here is the plan: https://dev.tiki.org/Cypht-integration

@jasonmunro
Copy link
Member Author

After much thought on this, I think the right thing to do here is re-license Cypht as LGPL instead of GPL. While it's possible to dual license LGPL and GPL, it does not make a lot of sense to do so. The LGPL is a bit of an odd license as it's focus is on 'libraries" as opposed to stand alone programs, but it protects what I care about (Cypht remains free as in beer and speech), and it facilitates integration with the Tiki project which is something else I really care about :)

@marclaporte
Copy link
Member

@jasonmunro : fantastic! It's simple and will make it easy to share some code.

Tiki is LGPL version 2.1.

Thank you very much!!

@jasonmunro
Copy link
Member Author

Finally getting around to this, and I can confirm html2text is the only dependency in Cypht that is going to be a problem. I can remove it and replace it with some home grown code that is adequate enough, but sadly it won't do as robust a job formatting the plain text to represent the HTML as this library does.

@dumblob
Copy link
Member

dumblob commented Apr 20, 2020

@mtibben would you be ok to relicense html2text as LGPL or something compatible?

@marclaporte
Copy link
Member

@jasonmunro Let's try to solve license issue to get best code and to participate upstream.

I was part of a team that this did this for Bootstrap: twbs/bootstrap#2054

My experience: most people are just as happy with any Open Source license, and most agree to switch to a license which permits the broadest adoption.

Libraries nowadays are mostly MIT-licensed.

Thanks!

@jasonmunro
Copy link
Member Author

@marclaporte Just planning a contingency in the case that the author has no interest in dual/changing licenses. We don't use this code a ton, but it does a nice job. I can probably do something decent in 10 or so lines of code, but most importantly I cannot move forward with this license change until this bit is resolved as you are aware because it is a license violation to do so.

@mtibben
Copy link

mtibben commented Apr 21, 2020

@mtibben would you be ok to relicense html2text as LGPL or something compatible?

See mtibben/html2text#71 - you'll need to ask the original author to relicense the code at http://www.chuggnutt.com/html2text

@marclaporte
Copy link
Member

@jasonmunro : understood.

I already reached out to Jon Abernathy (@chuggnutt). We'll start the process to reach out to all contributors. If we are not ready in time, we can do a release with 10-lines-of-code-interim-solution. And hopefully, it the next release, we'll restore html2text, and even make contributions :-)

If it doesn't work out, we could set it up so 10-lines-of-code becomes built-in solution but end users can easily install additional dependencies themselves. If present, it would override. We have tools in Tiki to help with this: http://doc.tiki.org/Packages
It would be overkill for just this use case, but there will be other use cases where this could be nice. Ex.: #382

Thanks!

@jasonmunro
Copy link
Member Author

work around is in place. It's closer to 30 lines of code but it also seems to be working a bit better than I planned :) (still not nearly as good as html2text)

@marclaporte
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation related enhancement suggest an improvement
Projects
None yet
Development

No branches or pull requests

4 participants