Platformization of examples #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wxtim
commented
Dec 15, 2021
•
wxtim
commented
- Closes TODO - platformise this example #336
- Closes TODO - consider a re-write once dynamic platform selection done #337
- Check for Non-platform config items in workflow chunks.
Added a cookie cutter warning that ideally most users shouldn't be writing their own warnings
wxtim
force-pushed
the
platformization_of_examples
branch
from
daf50d8 to
5249996
Compare
Co-authored-by: Oliver Sanders <[email protected]>
|
@oliver-sanders - Responded to your review, but deliberately not resolved comments so that you can see my responses. |
wxtim
force-pushed
the
platformization_of_examples
branch
from
df8e5b1 to
d3328ad
Compare
Co-authored-by: Melanie Hall <[email protected]>
Co-authored-by: Melanie Hall <[email protected]>
| platform = $(script-which-returns-a-platform-name) | ||
|
|
||
| Job hosts are always selected dynamically, for the chosen platform or | ||
| platform group. |
There was a problem hiding this comment.
Worth adding a paragraph explaining what happens if the command exits with a non-zero return code or bump to a new issue.
There was a problem hiding this comment.
I've bumped this to #374 because:
- I've not been well enough to deal today with it.
- This PR may be at risk horrid conflicts with Mel's work.
oliver-sanders
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.