Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idleTimeout should be added to close idle connections #148

Open
cyjake opened this issue Jul 26, 2021 · 0 comments · Fixed by #159
Open

idleTimeout should be added to close idle connections #148

cyjake opened this issue Jul 26, 2021 · 0 comments · Fixed by #159

Comments

@cyjake
Copy link
Owner

cyjake commented Jul 26, 2021

...to prevent connection squatting. The default max connections in mysql is 100-151:

mysql> show variables like 'max_connections';
+-----------------+-------+
| Variable_name   | Value |
+-----------------+-------+
| max_connections | 151   |
+-----------------+-------+
1 row in set (0.03 sec)
cyjake added a commit that referenced this issue Aug 16, 2021
fixes #148, closes #60 with a mocked Pool and Connection for sqlite driver
cyjake added a commit that referenced this issue Aug 16, 2021
fixes #148, closes #60 with a mocked Pool and Connection for sqlite driver
cyjake added a commit that referenced this issue Aug 17, 2021
fixes #148, closes #60 with a mocked Pool and Connection for sqlite driver
JimmyDaddy pushed a commit that referenced this issue Aug 17, 2021
* feat: close connections that exceeds opts.idleTimeout

fixes #148, closes #60 with a mocked Pool and Connection for sqlite driver

* test: SQLite driver.pool connections

* test: findOne({ where }) in sequelize adapter
@cyjake cyjake reopened this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant