Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo? #44

Closed
AlbertoJaenal opened this issue Nov 29, 2023 · 1 comment · Fixed by #46
Closed

Possible typo? #44

AlbertoJaenal opened this issue Nov 29, 2023 · 1 comment · Fixed by #46

Comments

@AlbertoJaenal
Copy link

Hi,
First of all, thanks and congrats to the researchers and developers for this amazing set of contributions. They are really handy and will impact the community quite positively!!
I was looking through the code to have a better understanding and I hit a place that may have a typo.
Here both neg0 and neg1 are assigned to the weight matrix using the same dimension (m), which may hold true when the number of elements is the same in both images, but out of that case it may not work.
Shouldn't it be weights[:, -1, :n] = neg1 ?
Best,
Alberto

@sarlinpe sarlinpe linked a pull request Dec 10, 2023 that will close this issue
@sarlinpe
Copy link
Member

sarlinpe commented Dec 10, 2023

Good catch, thanks for bringing it up. This does not affect the training since n == m but we'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants