Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix from Igor Tagintsev #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix from Igor Tagintsev #10

wants to merge 2 commits into from

Conversation

IgorTagintsev
Copy link
Collaborator

yevhentrofimenko
yevhentrofimenko reviewed Sep 29, 2018
View reviewed changes
Copy link
Contributor

@yevhentrofimenko yevhentrofimenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay because finally "a" or "b" will be 0, and that's why it works correct. But for more clear read it's better to use max(a, b). But it's nuances generally you did a great job!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevhentrofimenko yevhentrofimenko yevhentrofimenko left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorTagintsev @yevhentrofimenko