Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire/builder/cram should call require.toUrl() before fetching modules #160

Open
unscriptable opened this issue Apr 16, 2014 · 1 comment
Open

wire/builder/cram should call require.toUrl() before fetching modules #160

unscriptable opened this issue Apr 16, 2014 · 1 comment
Assignees
@unscriptable

Comments

@unscriptable
Copy link
Member

wire/builder/cram should ensure it calls require.toUrl() before fetching modules. Otherwise, the paths/packages config is skipped. It might seem strange, but this is just how cram plugins work. :)
@unscriptable unscriptable self-assigned this Apr 16, 2014
@unscriptable
Copy link
Member Author

Adding @tomatau who helped diagnose the problem on irc. :)

unscriptable added a commit that referenced this issue Apr 16, 2014
@unscriptable
Call require.toUrl() on spec ids.
c034907 
require.toUrl() ensures that ids are converted to paths via the `paths` and `packages` AMD config options.
Fixes #160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unscriptable unscriptable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@unscriptable