version number in compiled files

[szepeviktor]

Could you please include version numbers in dist files.

[szepeviktor]

I've spotted version="0.8.9" in the middle of the minified.
Could it be in the comment line?
5 bytes wasted! + the space before it

[unscriptable]

Hey @szepeviktor, I'm not sure what the problem is. Can you restate the problem? Thanks! -- John

[szepeviktor]

When I open curl.js I cannot detect the version visually.

[szepeviktor]

Could you include the version number above the MIT License line?

[unscriptable]

Hey @szepeviktor,

I would gladly accept a PR for this feature. It seems that it's possible to do this in the bin/make.sh script by parsing src/curl.js for something like /version\s*=\s*['"]([^'"]*)['"]/, outputting the version comment to a temp file, and then concatenating the temp file with the usual output at the end of the file.

Interested?

-- John

[szepeviktor]

Where would you insert it?
../src/curl.js ../src/curl/domReady.js ../src/curl/plugin/js.js ../src/curl/plugin/domReady.js

[szepeviktor]

"at the end of the file."

[unscriptable]

At the end of this file: https://github.com/cujojs/curl/blob/master/bin/make.sh#L38

[szepeviktor]

I meant the version string.
#275

[szepeviktor]

Were you thinking about searching ../src/curl.js hardcoded instead the compressed code?

[unscriptable]

Yes, I think it is more likely that the closure compiler will change how it compresses the code than I will change how I code the version variable.

[szepeviktor]

OK, hardcoding....