Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reason for not including utilities of modelVersion < 10.0 is not clear #30

Open
edwingamboa opened this issue Aug 27, 2018 · 2 comments
Labels
discussion This issue need a discussion of the team. enhancement [email protected] It schould be implemented for cubx.core.rte 3.x version.

Comments

@edwingamboa
Copy link
Member

edwingamboa commented Aug 27, 2018

AS-IS

When developing an artifact in [email protected] that has a utility with modelVersion < 10.x as a dependency, the component cannot be initialised and console errors are logged (See attached image).

The warning message about the modelVersion is as follows:

Webpackage with id [webpackageId] has modelVersion 9.1.1. This CRC (version=3.0.0-SNAPSHOT) supports the following modelVersion(s): 10.0

Then, the error message looks as follows:

The artifact '[artifact-id]' is not defined in manifest:
Dependency reference: ...

Although the DepMgr logs a warning indicating that the utility is not modelVersion 10.0 before those errors, it is not straightforward to conclude that the errors are due to the modelVersion.

TO-BE

The warning message should indicate that the webpackage will be not included as dependency, and not only say the utility has a different modelVersion.

Webpackage with id [webpackageId] has modelVersion 9.1.1, and this CRC (version=3.0.0-SNAPSHOT) supports the following modelVersion(s): 10.0. Thus, the webpackage and its artifacts will be excluded.

consolelogsdepmgrmodelversion

@edwingamboa edwingamboa added discussion This issue need a discussion of the team. enhancement [email protected] It schould be implemented for cubx.core.rte 3.x version. labels Aug 27, 2018
@edwingamboa
Copy link
Member Author

@jtrs @pwrinc I just noticed that the warnings about the modelVersion are logged. However, I think that is not straightforward to relate the errors to the warnings. The error message says that the artifact is not defined in the manifest, however, it is actually defined but was excluded due to the modelVersion.

@pwrinc
Copy link
Member

pwrinc commented Oct 11, 2018

Suggestion: Throw an error instead of the warning. If this error occurs we should stop Dependency Resolution (suppress event DepMgr ready and throw a new error Event).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue need a discussion of the team. enhancement [email protected] It schould be implemented for cubx.core.rte 3.x version.
Projects
None yet
Development

No branches or pull requests

2 participants