Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deleting cards? #43

Open
cthiel opened this issue Aug 3, 2011 · 4 comments
Open

Enable deleting cards? #43

cthiel opened this issue Aug 3, 2011 · 4 comments

Comments

@cthiel
Copy link
Owner

cthiel commented Aug 3, 2011

How do we want to handle deleting cards? With a link/button from the edit view?

@garrett
Copy link
Collaborator

garrett commented Aug 3, 2011

  • We should have an (X) icon on hover.
  • No confirmation dialog.
  • We should have undo, in case it really was an accident.
  • Undo would show up in the status area.
  • The status area is the "titlebar" at the top... in the center.. where "CardBoard" is now. The title would move to the left and more global actions would show up on the right. Navigation would also be in the title area, next to the title of the current board.

@ghost ghost assigned bear454 Aug 3, 2011
@garrett
Copy link
Collaborator

garrett commented Aug 7, 2011

I just added card deletions in master. (I wrote it on the train.) It seems to work pretty well.

However, when we delete the card with a HTTP DELETE, it is successful, but Ruby returns an error (even though it works).

Also, I don't have undos implemented yet, but I think I could store each revision in an array and roll back and forward. This would work at least during the session and be pretty fast. Perhaps we could have undo/redo in the top bar when applicable. (I'm not sure if we really want a redo, or how many levels we should undo. Is one enough, or should we have more?)

Since deletion of cards work, but with this error, I would consider this bug done once we have the response fixed. We should move the undo stuff into an undo bug.

@garrett
Copy link
Collaborator

garrett commented Aug 7, 2011

I opened issue #44 for undo/redo support.

@cthiel
Copy link
Owner Author

cthiel commented Aug 7, 2011

I know what causes the server to return an error. Caching is broken when deleting cards. I'll look into fixing this soon.

@bear454 bear454 removed their assignment Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants