Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly fill event.lst.tel[X].first_capacitor_id with the correct array #118

Open
maxnoe opened this issue Nov 11, 2021 · 2 comments
Open

Directly fill event.lst.tel[X].first_capacitor_id with the correct array #118

maxnoe opened this issue Nov 11, 2021 · 2 comments

Comments

@maxnoe
Copy link
Member

maxnoe commented Nov 11, 2021

Instead of storing the first_caps array in the LSTR0Corrections, we can just put the correct array of shape (N_GAIN, N_PIXELS) into the event.

This will make it accessible also to the scripts in lstchain that at the moment recalculate it.
@FrancaCassol
Copy link
Collaborator

Hi @maxnoe,
this implies a request to change the data model, for the moment only the "first cell id" is foreseen

@maxnoe
Copy link
Member Author

maxnoe commented Nov 15, 2021

No, it does not change anything about the R1 data model. It would be completely internal to the analysis software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxnoe @FrancaCassol