Parsing SVGs to internal vector format #43
Replies: 15 comments 19 replies
-
|
This isn't really a formal bug report, so I'm moving it to Discussions. |
Beta Was this translation helpful? Give feedback.
-
Batik has enough bugs, both in the main code and its testing infrastructure, that one cannot reliably run their test suite. Their tests aren't reproducible, if you do not believe this please try to run their "regard test suite". IMO that's the main reason why they do not fix bugs unless they have a CVE attached.
After a lot of work, I managed to transform Batik's tests into something that can be run consistently from CI (at least on Windows). If I write a patch I can reliably check for regressions, so I believe that this project is at least a better place. I'll look at your issues and see what I can do. |
Beta Was this translation helpful? Give feedback.
-
Hello Dan, I've looked at those issues and there seems to be the assumption that Batik is causing certain problems, but I do not see any Batik-specific investigation that I could use. I'm not familiar with your software and do not know what happens under the hood. I'd suggest that you open one or more issues here, each with a sample SVG image that allows to clearly reproduce the problem (with authorisation to include the image as a new rendering test in this project), and also the expected/obtained rendering. You may want to look at The file If you aren't rendering but instead expect a specific value being obtained from some EchoSVG/Batik method, you should also give the relevant values and information to reproduce. I look forward your issues being opened. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for taking a look. Do I understand correctly that your fork should be a direct replacement for batik? after changing include paths and module-info, of course. API the same, implementation changed. Our project is maven-based. I see your getting started instructions are all for gradle and build-it-yourself. is there a maven central dependency I can use? |
Beta Was this translation helpful? Give feedback.
-
Yes it is, except for a small set of changes. See MIGRATING_FROM_BATIK.
None of my projects are on Maven Central, but you could set up the following repository in your <repositories>
<repository>
<id>css4j</id>
<name>CSS4J repository</name>
<url>https://css4j.github.io/maven/</url>
</repository>
</repositories>Although I recommend using Gradle because with Maven you cannot configure which artifacts are downloaded from a given repository. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, I'm trying it now. |
Beta Was this translation helpful? Give feedback.
-
|
for maven i added <repositories>
<!-- for echoSVG -->
<repository>
<id>css4j</id>
<name>CSS4J repository</name>
<url>https://css4j.github.io/maven/</url>
</repository>
</repositories>and in module-info.java requires io.sf.carte.echosvg;then fixed all import commands. The only issue stopping my build now is SVGDocument newDocumentFromInputStream(InputStream in) throws Exception {
String parser = XMLResourceDescriptor.getXMLParserClassName();
SAXSVGDocumentFactory factory = new SAXSVGDocumentFactory(parser);
return (SVGDocument) factory.createDocument("",in);
}The system claims it doesn't recognize requires io.sf.carte.echosvg.util;and now i need a hint, please. |
Beta Was this translation helpful? Give feedback.
-
Yes the |
Beta Was this translation helpful? Give feedback.
-
|
So based on the private static SVGDocument newDocumentFromInputStream(InputStream in) throws Exception {
SAXDocumentFactory factory = new SAXSVGDocumentFactory();
return (SVGDocument)factory.createDocument(null,in);
}and now I get a runtime boot layer failure becaues of |
Beta Was this translation helpful? Give feedback.
-
Details please? Is it the known issue due to If that is the case, use a Maven dependency exclusion like: <exclusions>
<exclusion>
<groupId>xml-apis</groupId>
<artifactId>xml-apis</artifactId>
</exclusion>
</exclusions>Otherwise I'll need more information, I do not use Maven anymore nor anyone else has complained about that. |
Beta Was this translation helpful? Give feedback.
-
|
I didn't get any warnings about xml-apis. The entire error message at run time is: I am working on branch https://github.com/MarginallyClever/Makelangelo-software/tree/replace-batik-with-css4j and running it with IJ. |
Beta Was this translation helpful? Give feedback.
-
|
clean and rebuild, now i get |
Beta Was this translation helpful? Give feedback.
-
|
This output is from Maven: [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ Makelangelo ---
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[ERROR] Error occurred during initialization of boot layer
[ERROR] java.lang.module.FindException: Module xalan not found, required by io.sf.carte.echosvg.domAnd then I recalled that I had this problem when I was using Maven. The module system is refusing to create a filename-based module name from the Xalan package because it is a service provider and it is not declaring a The workaround is to declare a module name with a plugin like Moditect. If you did not see a similar problem with Batik is probably due to that project not being modularised. |
Beta Was this translation helpful? Give feedback.
-
Exactly, the JPMS wants Xalan to have a Perhaps I should create a EchoSVG FAQ containing this, what do you think? |
Beta Was this translation helpful? Give feedback.
-
|
Yes. Once we get this working a concise "how to with maven" would be great. |
Beta Was this translation helpful? Give feedback.
-
|
MarginallyClever/Makelangelo-software#645 |
Beta Was this translation helpful? Give feedback.
-
I wrote that above: a valid bug report explaining what one needs to reproduce the issue with EchoSVG (not with your software). For now, this is what I get when I render the SVG in MarginallyClever/Makelangelo-software#492 with EchoSVG:
which seems to be the correct result. |
Beta Was this translation helpful? Give feedback.
-
|
Well then my question is "how did you get it to run?" I'm still trying to get around the BSFManager problem to execute the debugger in IntelliJ. |
Beta Was this translation helpful? Give feedback.
-
|
I see that xalan-2.7.2.jar from maven central has a META-INF/services/org.apache.xalan.extensions.bsf.BSFManager file declaring org.apache.bsf.BSFManager as a provider ... but org.apache.bsf doesn't exist in the JAR. |
Beta Was this translation helpful? Give feedback.
-
I see your bug reports to the Xalan people, and raise my pull request to Xalan-Java. At least it has been tried. As for how to work around this: with Gradle, either |
Beta Was this translation helpful? Give feedback.
-
|
And the new FAQ talks about this... |
Beta Was this translation helpful? Give feedback.
-
|
great. can i please get the maven moditect settings?
…On Thu, Apr 7, 2022 at 11:35 AM carlosame ***@***.***> wrote:
And the new FAQ <https://github.com/css4j/echosvg/blob/master/FAQ.md>
talks about this...
—
Reply to this email directly, view it on GitHub
<#43 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALFRBTHZ4THXNH53O4YFGLVD4TITANCNFSM5SOPPWDQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Dan Royer
Owner, Marginally Clever Robots, Ltd.
------------------------------
1 (604) 259 9564 <16042599564> ***@***.***
https://marginallyclever.com <http://www.marginallyclever.com>
<https://www.facebook.com/MarginallyClever/>
<https://www.instagram.com/imakerobots/>
<https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw>
<https://twitter.com/MarginallyC> <https://github.com/MarginallyClever/>
|
Beta Was this translation helpful? Give feedback.
-
|
The Xalan issue is something that anyone trying to use Maven is going to find. Although my advice is always to migrate from Maven to Gradle (because Maven is not friendly to smaller, non-central repositories), the current situation is unacceptable and I decided to get rid of the Xalan dependency. |
Beta Was this translation helpful? Give feedback.
-
|
That's awesome! Please let me know when I can update with that change. |
Beta Was this translation helpful? Give feedback.
-
loads for me like the last part of the curve is wrong, namely When I parse it I in my app what I receive from My code for this test begins here: On the chance that I'm going blind with age, can you see what I'm doing wrong? Did I forget a + that should be a -? |
Beta Was this translation helpful? Give feedback.
-
|
To be clear: the previous post was made while testing with echosvg 0.2. |
Beta Was this translation helpful? Give feedback.
-
|
What looks wrong to me is the |
Beta Was this translation helpful? Give feedback.
-
|
Hello! I hope you're doing well. I had enough motivation to day to jump into this again and updated the original bug on makelangelo software with a more thorough analysis of what's going on. I'm using EchoSVG 0.2 and getting the same glitch I had with Batik so...the bug was ported over? |
Beta Was this translation helpful? Give feedback.
-
Hi Dan, I'm happy to hear that you are using EchoSVG, and it is unfortunate that you are still facing that problem. I did not write the implementation of As to how to fix this, IMHO debugging your issue is something that belongs to the developers in your project. My development resources are limited (I manage about 18 open source repositories and occasionally contribute to upstream dependencies), so if you could come up with a PR I could review it, or if you have a more specific suggestion I could try looking at it at some point, but that's all. Sorry if that's disappointing but I'm not able to do a lot more, and my priorities are with the pinned issues (which are big enough already). |
Beta Was this translation helpful? Give feedback.
-
|
alright, I respect that. I tried digging into getNormalizedPathSegList and didn't get very far. With the amount of code you're managing we're probably equally familiar with the underpinnings. I've looked for Batik documentation, too, with no luck. I'll try using |
Beta Was this translation helpful? Give feedback.
-
|
I don't know if this qualifies as a bug yet... when trying to load <svg xmlns="http://www.w3.org/2000/svg" width="320" height="320">
<path d="M 10 315
L 110 215
A 36 60 0 0 1 150.71 170.29
L 172.55 152.45
A 30 50 -45 0 1 215.1 109.9
L 315 10" stroke="black"/>
<circle cx="150.71" cy="170.29" r="2" fill="red"/>
<circle cx="110" cy="215" r="2" fill="red"/>
<ellipse cx="144.931" cy="229.512" rx="36" ry="60" fill="transparent" stroke="blue"/>
<ellipse cx="115.779" cy="155.778" rx="36" ry="60" fill="transparent" stroke="blue"/>
</svg>ellipse elements seem to make it mad. |
Beta Was this translation helpful? Give feedback.
-
|
Looks like you are having a classloader problem (the MissingResourceException). What I get is the following: The attribute "fill" represents an invalid CSS value ("transparent").
Original message:
The "transparent" identifier is not a valid value for the "fill" property.
org.w3c.dom.DOMException: file:/C:/***/echosvg/samples/ellipses.svg:
The attribute "fill" represents an invalid CSS value ("transparent").
Original message:
The "transparent" identifier is not a valid value for the "fill" property.
at io.sf.carte.echosvg.css.engine.CSSEngine.getCascadedStyleMap(CSSEngine.java:733)
at io.sf.carte.echosvg.css.engine.CSSEngine.getComputedStyle(CSSEngine.java:819)
at io.sf.carte.echosvg.bridge.CSSUtilities.getComputedStyle(CSSUtilities.java:85)
at io.sf.carte.echosvg.bridge.CSSUtilities.convertDisplay(CSSUtilities.java:523)
at io.sf.carte.echosvg.bridge.GVTBuilder.buildGraphicsNode(GVTBuilder.java:204)
at io.sf.carte.echosvg.bridge.GVTBuilder.buildComposite(GVTBuilder.java:171)
at io.sf.carte.echosvg.bridge.GVTBuilder.build(GVTBuilder.java:84)
at io.sf.carte.echosvg.transcoder.SVGAbstractTranscoder.transcode(SVGAbstractTranscoder.java:241)
at io.sf.carte.echosvg.transcoder.image.ImageTranscoder.transcode(ImageTranscoder.java:97)So the problem is caused by the lack of support for the |
Beta Was this translation helpful? Give feedback.
-
|
EchoSVG now supports the |
Beta Was this translation helpful? Give feedback.
-
|
Given that this discussion is receiving some attention these days, I wanted to point out that the issue with |
Beta Was this translation helpful? Give feedback.
-
Hello! Glad to find a java svg parse that is active.
We're using Batik in makelangelo software and either it has issues or I'm really bad at reading the documentation. I'm looking for an alternative that avoids the issues we've run across.
Have I come to the right place?
Beta Was this translation helpful? Give feedback.
All reactions