Skip to content
This repository has been archived by the owner on May 21, 2018. It is now read-only.

declare module is used even when CompatibilityVersion >= 1.5 #60

Open
aluanhaddad opened this issue Jun 30, 2016 · 2 comments
Open

declare module is used even when CompatibilityVersion >= 1.5 #60

aluanhaddad opened this issue Jun 30, 2016 · 2 comments

Comments

@aluanhaddad
Copy link

aluanhaddad commented Jun 30, 2016 •
edited
Loading

TypeScript 1.5 introduced the declare namespace syntax as an alias for the declare module syntax in order to disambiguate external and internal modules. The recommended practice is to avoid the old declare module when declaring an what were called internal modules and are now called namespaces in TypeScript terminology. See microsoft/TypeScript/pull/2923 where Anders Hejlsberg explains the change.
aluanhaddad added a commit to aluanhaddad/t4ts that referenced this issue Jun 30, 2016
@aluanhaddad
Use declare namespace syntax when possible
2aae4a3 
This resolves cskeppstedt#60
@aluanhaddad aluanhaddad mentioned this issue Jun 30, 2016
Closed
aluanhaddad added a commit to aluanhaddad/t4ts that referenced this issue Jun 30, 2016
@aluanhaddad
Patch 1 (#2)
d63f554 
* Use declare namespace syntax when possible

This resolves cskeppstedt#60

* Add test (#1)

* Fix default behavior
@aluanhaddad aluanhaddad mentioned this issue Jun 30, 2016
Closed
@cskeppstedt
Copy link
Owner

Hi @aluanhaddad and thanks for your contributions! Unfortunately I am no longer maintaining this project, I just updated the README: 75f4003. Sorry :/

@aluanhaddad
Copy link
Author

@cskeppstedt Convenient timing actually, I just switched to https://frhagn.github.io/Typewriter/ because I saw that you hadn't merged anything for a while. Anyway, no worries thanks for this library, it was useful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use declare namespace syntax when possible aluanhaddad/t4ts
2 participants
@cskeppstedt @aluanhaddad