-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Yojson dependency optional #22
Comments
Hello, I think that there are several points that may help use
(1.) is straightforward and I'll deprecate the function in the next release (or maybe replace it with a opaque formatter compatible with I'm not sure (2.) is too useful, but does not hurt. (3.) is a bit tricky to do in a safe way. My current plan is to change the type of
And add an Another way could be to add a phantom type parameter like I'm not sold on either of this approaches, I'll have to try a bit. Thanks for this suggestion! |
Is there a need for serialization to be in JSON? If not, maybe choosing an approach that makes serialization independent from the format would be nice, no? |
A problem with that is that with the current approach, a reference to the serialization functions needs to be kept in each
For these reasons I think that sticking to json is good enough :) |
Dynamic records are useful even without JSON serialisation.
It would be convenient to be able to use the
records
library withoutYojson
.The text was updated successfully, but these errors were encountered: