Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After a key has been generated, it is not possible to create a new one #47

Open
dehekkendekrekker opened this issue Jul 6, 2014 · 2 comments

Comments

@dehekkendekrekker
Copy link

To reproduce:

  1. Start irssi
  2. /load otr
  3. /otr genkey foo@bar
  4. check with with "ps -eLf|grep irssi" that there are two irssi threads.
  5. You will not get a confirmation message that key generation has completed.
  6. check with with "ps -eLf|grep irssi" that there is one irssi thread.
  7. /otr genkey foo@bar
  8. Observe that a message appears that keygen has completed, and a new one is started
  9. check with with "ps -eLf|grep irssi" that there is one irssi thread.
@dehekkendekrekker
Copy link
Author

This issue is related to #24 and #46

@dgoulet
Copy link
Member

dgoulet commented Jan 3, 2015

(Oh wow... I totally failed to reply before.... Really sorry)

Right, the key generation is a bit wanky and by that I mean that the irssi plugin uses a thread to start the key generation and that thread can not notify the main irssi process of completion else we end up in bad memory territory.

So the way to go around that limitation is that every "otr events" and private message sent/received, the plugin checks if the key generation thread is done and if so will print the completion message in the main process.

Double key generation should work, I just tested out, the previous key will be replaced. Can you confirm that the otr.key file doesn't change with your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants