Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

needless dependencies? #31

Closed
anarcat opened this issue May 10, 2013 · 3 comments
Closed

needless dependencies? #31

anarcat opened this issue May 10, 2013 · 3 comments

Comments

@anarcat
Copy link
Contributor

anarcat commented May 10, 2013

I am trying to figure out why the Debian package (#26) is giving me this warning:

dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/irssi-plugin-otr/usr/lib/irssi/modules/libotr.so was not linked against libgmodule-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/irssi-plugin-otr/usr/lib/irssi/modules/libotr.so was not linked against librt.so.1 (it uses none of the library's symbols)

We don't specify any extra -lib to link against in our side of the build process, could there be too many depends in configure.ac?
@dgoulet
Copy link
Member

dgoulet commented May 10, 2013

These are for irssi headers. Without gmodule, the irssi header configure check and compilation fail.

However, the gmodule libs are not needed at linking time (only the cflags) so I'll push a fix for that later on. Thanks for the report!

dgoulet added a commit that referenced this issue May 10, 2013
@dgoulet
Fix: remove gmodule useless linked library flags
c3f7b4a 
Only the CFLAGS are needed for irssi headers to make sense.

Ref #31

Reported-by: Antoine Beaupré <[email protected]>
Signed-off-by: David Goulet <[email protected]>
@dgoulet
Copy link
Member

dgoulet commented May 10, 2013

Tell me if this fixes it and we'll close after that.

@anarcat
Copy link
Contributor Author

anarcat commented May 10, 2013

It does, the only thing the Debian police finds now is this:

dpkg-shlibdeps: warning: debian/irssi-plugin-otr/usr/lib/irssi/modules/libotr.so contains an unresolvable reference to symbol servers: it's probably a plugin
dpkg-shlibdeps: warning: 26 other similar warnings have been skipped (use -v to see them all)

But I think that's fine, thanks!

@anarcat anarcat closed this as completed May 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anarcat @dgoulet