Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The integration test is not smart enough to detect used ports #225

Open
damoncro opened this issue Nov 24, 2021 · 2 comments
Open

The integration test is not smart enough to detect used ports #225

damoncro opened this issue Nov 24, 2021 · 2 comments
Assignees
Labels
tests This issue is related to unit or integration tests

Comments

@damoncro
Copy link
Contributor

damoncro commented Nov 24, 2021

Describe the bug
Now in the integration test, the fixture uses fixed network ports. If some ports are used, the integration test will lead to fail, which should be avoided, especially the test sometimes takes very long and the development would become difficult and time-consuming on troubleshooting.

To Reproduce
Create any process that may use the port that any fixture will use.

Expected behavior
The program should use random ports that available on the operating system.

@damoncro damoncro self-assigned this Nov 25, 2021
@yihuang
Copy link
Collaborator

yihuang commented Dec 3, 2021

Random ports might make more sense running tests in CI.
But fixed ports do have the advantage of being predictable development, currently, some testing codes depend on that to know which port to wait.
I suggest giving this issue a lower priority.

@damoncro
Copy link
Contributor Author

damoncro commented Dec 3, 2021

I see, it is ok to add an option to enable the random port feature to speed up test development (sometimes ports being used is annoying in test).

@yihuang yihuang added the tests This issue is related to unit or integration tests label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests This issue is related to unit or integration tests
Projects
None yet
Development

No branches or pull requests

2 participants