Problem: integration test shell includes dev tools

[yihuang]

Solution:

• remove dev tools from integration test shell
  • some dev tools are moved into flake.nix, use nix develop.
  • dapp is in contracts/shell.nix
  • solc is in nix/gen-binding-shell.nix

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• Chores
  • Removed unnecessary dependencies from the integration testing environment to streamline the setup process.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the integration_tests/shell.nix file, specifically the removal of several dependencies from the buildInputs list within the pkgs.mkShell function. The removed packages include pkgs.jq, pkgs.go, pkgs.gomod2nix, pkgs.poetry, pkgs.git, pkgs.dapp, pkgs.nixfmt-rfc-style, and pkgs.rocksdb. While the calls to rename certain executables are retained, the renamed executables are no longer included in the buildInputs. The overall structure of the shell environment remains unchanged.

Changes

File	Change Summary
integration_tests/shell.nix	Removed multiple dependencies from buildInputs in pkgs.mkShell; retained renameExe calls but excluded renamed executables from buildInputs.

Possibly related PRs

• Problem: latest hermes is not used in integration tests #1361: Modifies nix/hermes.nix, related to environment setup in integration tests.
• Problem: app hash mismatch in block-stm #1539: Involves changes in go.mod and gomod2nix.toml for dependency management, relevant to the dependency removals.
• Problem: fail test is not reported in ci #1622: Includes modifications in .github/workflows/build.yml, which may relate to the testing process impacted by the changes.
• Problem: iavl rollback not tested #1693: Updates in integration_tests/test_rollback.py and integration_tests/configs/rollback.jsonnet involve testing configurations that could be indirectly related.
• Problem: iavl prune fix is not included #1702: Changes to go.mod and CHANGELOG.md regarding dependency management and bug fixes, relevant to the removal of dependencies.

Suggested reviewers

• mmsqe
• devashishdxt

🐰 In the meadow, where bunnies play,
Dependencies gone, hip-hip-hooray!
A cleaner shell for tests to run,
Hopping along, we’ve just begun!
With every change, we leap and bound,
In our happy burrow, joy is found! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 86c5cc4 and f3fac71.

📒 Files selected for processing (1)

• integration_tests/shell.nix (0 hunks)

💤 Files with no reviewable changes (1)

• integration_tests/shell.nix

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.88%. Comparing base (a3c2f70) to head (f3fac71).
Report is 11 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1708   +/-   ##
=======================================
  Coverage   16.87%   16.88%           
=======================================
  Files          72       72           
  Lines        6163     6167    +4     
=======================================
+ Hits         1040     1041    +1     
- Misses       5000     5002    +2     
- Partials      123      124    +1