Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance visibility of blacklist hash logging at startup for production nodes #1333

Closed
Perseverance42 opened this issue Mar 3, 2024 · 3 comments

Comments

@Perseverance42
Copy link

The addition of logging for blacklisted addresses (referenced in #1328) currently employs the info log level. Given that production nodes predominantly operate at the warn level, operators are compelled to adjust the log level to facilitate the cross-verification of blacklist hashes with peers. This adjustment necessitates node restarts, introducing avoidable restarts in production environments.

Considering that this logging activity is confined to node startup, elevating these log messages to a higher severity would significantly enhance operational efficiency by obviating the need for manual log level modifications and subsequent restarts.

@Perseverance42
Copy link
Author

Considering the straightforward nature of the proposed code changes, I believe this issue would serve as an excellent opportunity for me to familiarize myself with the project's contribution process. It appears to be a manageable task that still encompasses all the necessary steps required for contributing. I'm eager to take this on as my first contribution. May I proceed?

@yihuang
Copy link
Collaborator

yihuang commented Mar 3, 2024

Considering the straightforward nature of the proposed code changes, I believe this issue would serve as an excellent opportunity for me to familiarize myself with the project's contribution process. It appears to be a manageable task that still encompasses all the necessary steps required for contributing. I'm eager to take this on as my first contribution. May I proceed?

sure, PR is welcome.

@mmsqe
Copy link
Collaborator

mmsqe commented Jul 5, 2024

fixed by #1334

@mmsqe mmsqe closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants