Problem: go 1.22 is not used

[yihuang]

Solution:

• update nixpkgs to unstable branch

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• Chores
  • Updated the Nixpkgs source to the latest unstable version for improved package availability and stability.
• Chores
  • Updated the Go version to 1.22.0 in various workflow files for consistency and compatibility.

[coderabbitai]

Walkthrough

The recent updates across multiple workflow files involve transitioning the Go version from 1.20.0 to 1.22.0, ensuring consistency and leveraging the latest features and improvements. Additionally, the flake.nix file was modified to switch the Nixpkgs URL from release-23.11 to nixpkgs-unstable, offering users access to cutting-edge packages with potential trade-offs in stability.

Changes

File	Change Summary
.github/workflows/build.yml	Updated go-version parameter in actions/setup-go@v3 step to ^1.22.0
.github/workflows/codeql-analysis.yml	Updated Go version to 1.22.0 in CodeQL analysis workflow
.github/workflows/lint.yml	Updated Go version to 1.22.0 and modified installation commands for tools in lint.yml
.github/workflows/sims.yml	Updated Go version to 1.22.0 in multiple places within the workflow file
flake.nix	Updated Nixpkgs URL from release-23.11 to nixpkgs-unstable

🐰✨
Code evolves, like a dance of light,
Go versions shift, embracing the night.
Nix's journey to the unstable beat,
Where bugs may roam and fixes meet.
In this realm of updates bold,
Innovation's tale, forever told.
🚀🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7c976f4 and 9f62ed0.

Files ignored due to path filters (3)

• flake.lock is excluded by: !**/*.lock
• go.mod is excluded by: !**/*.mod
• nix/sources.json is excluded by: !**/*.json

Files selected for processing (1)

• flake.nix (1 hunks)

Additional comments: 1

flake.nix (1)

• 3-3: Switching the Nixpkgs source to nixpkgs-unstable effectively updates the project to use Go version 1.22, aligning with the PR's objectives. However, using the unstable branch might introduce instability or compatibility issues with other dependencies. It's recommended to thoroughly test the entire project to ensure that all dependencies and functionalities remain stable and compatible with the new Go version and other updated packages from the unstable branch.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9f62ed0 and 9c9917a.

Files selected for processing (4)

• .github/workflows/build.yml (1 hunks)
• .github/workflows/codeql-analysis.yml (1 hunks)
• .github/workflows/lint.yml (2 hunks)
• .github/workflows/sims.yml (6 hunks)

Files skipped from review due to trivial changes (3)

• .github/workflows/build.yml
• .github/workflows/codeql-analysis.yml
• .github/workflows/sims.yml

Additional comments: 2

.github/workflows/lint.yml (2)

• 25-25: The Go version has been updated to 1.22.0 to align with the PR's objective of utilizing Go version 1.22. This change is straightforward and correctly updates the Go version for the linting job. Ensure that all Go-related tools and dependencies in the project are compatible with Go 1.22.0.
• 41-41: The installation commands for golangci-lint and rocksdb have been updated to use nix profile install. This change aligns with the Nix ecosystem's best practices for managing profiles and packages. However, it's important to verify that these commands work as expected in the CI environment, especially since they rely on the Nix package manager's functionality, which might behave differently across environments.

Additionally, consider adding a comment explaining why nix profile install is used instead of other Nix commands, such as nix-env, for future maintainers who might not be familiar with the nuances of Nix package management.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7c976f4 and b6fbab5.

Files ignored due to path filters (3)

• flake.lock is excluded by: !**/*.lock
• go.mod is excluded by: !**/*.mod
• nix/sources.json is excluded by: !**/*.json

Files selected for processing (5)

• .github/workflows/build.yml (1 hunks)
• .github/workflows/codeql-analysis.yml (1 hunks)
• .github/workflows/lint.yml (2 hunks)
• .github/workflows/sims.yml (6 hunks)
• flake.nix (1 hunks)

Files skipped from review as they are similar to previous changes (5)

• .github/workflows/build.yml
• .github/workflows/codeql-analysis.yml
• .github/workflows/lint.yml
• .github/workflows/sims.yml
• flake.nix