Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(csv): bump csv min k8s version to 1.25 #910

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jul 8, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: cryostatio/cryostatio.github.io#194

Description of the change:

Bumped min k8s version in CSV to 1.25.0

Motivation for the change:

See cryostatio/cryostatio.github.io#194 (comment). Might be a little odd if anyone already installs cryostat-operator with 1.21-1.24 k8s.

@tthvo tthvo added chore Refactor, rename, cleanup, etc. safe-to-test labels Jul 8, 2024
@tthvo tthvo requested review from andrewazores and ebaron July 8, 2024 19:36
@andrewazores
Copy link
Member

@ebaron looks like I missed this when preparing the upstream release. I updated the process doc at least. I guess we should merge and backport this, and document it as an upstream known issue in the release discussion?

@andrewazores andrewazores merged commit f84caf0 into cryostatio:main Jul 9, 2024
5 checks passed
@andrewazores
Copy link
Member

mergify bot pushed a commit that referenced this pull request Jul 9, 2024
Signed-off-by: Thuan Vo <[email protected]>
(cherry picked from commit f84caf0)

# Conflicts:
#	bundle/manifests/cryostat-operator.clusterserviceversion.yaml
ebaron pushed a commit that referenced this pull request Jul 9, 2024
* chore(csv): bump csv min k8s version to 1.25 (#910)

Signed-off-by: Thuan Vo <[email protected]>
(cherry picked from commit f84caf0)

# Conflicts:
#	bundle/manifests/cryostat-operator.clusterserviceversion.yaml

* fixup! chore(csv): bump csv min k8s version to 1.25 (#910)

---------

Co-authored-by: Thuan Vo <[email protected]>
Co-authored-by: Andrew Azores <[email protected]>
@tthvo tthvo deleted the k8s-min branch July 9, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upstream docs specify a different min k8s version than OperatorHub
3 participants