Add a Server-Side Applicator #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2022
muvaf
changed the title
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
…so that it can accept owner-per-call such as composite resource name Signed-off-by: Muvaffak Onus <[email protected]>
|
It looks like this is mostly ready to use, what else would be needed to start having providers take advantage of it? Maybe a |
|
I'm going to close this. We are still investigating this avenue per crossplane/crossplane#4047, but @muvaf hasn't touched this PR in a while and is no longer working on Crossplane full-time so I don't think we're likely to get this implementation merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds the ability to utilize server-side apply mechanism by providers and core Crossplane. Unfortunately,
ApplyOptionargument is not relevant for this method since there is no fetching of an existing object. However, there are some patching options that users may want to set per-call, especially the owner. Initially, it was part ofNewAPIServerSideApplicatorfunction but that'd force you to use single owner for many calls, i.e. we'd have to usecompositeas owner for all managed resources. Now, we can actually use the composite name, which would be more accurate and helpful for debugging purposes.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests and basic usage test. I'll expand this section with more usage in composition.