Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with GitHub-enterprise GitHub instance #23

Closed
sebastienbrunkyndryl opened this issue Mar 23, 2023 · 3 comments
Closed

Usage with GitHub-enterprise GitHub instance #23

sebastienbrunkyndryl opened this issue Mar 23, 2023 · 3 comments

Comments

@sebastienbrunkyndryl
Copy link

Hello,

In order to use the provider with a GitHub-enterprise instance it's required to set base_url property, but I don't retrieve the properties into to "providerconfigs.github.upbound.io" CRD.

Could you add an example to explain how to make it ?

@AtzeDeVries
Copy link
Collaborator

AtzeDeVries commented Apr 12, 2023

Hi @sebastienbrunkyndryl

Sorry for the late reply. I think you should configure the base url via the credentials. See https://github.com/coopnorge/provider-github#adding-provider-config

apiVersion: v1
kind: Secret
metadata:
  name: provider-secret
  namespace: upbound-system
type: Opaque
stringData:
  credentials: "{\"token\":\"${GH_TOKEN}\",\"owner\":\"${GH_OWNER}\"}"

So modify the credentials key in order to support GHE. The format of the json is the same as configuring the terraform provider: https://registry.terraform.io/providers/integrations/github/latest/docs#argument-reference

I cannot test this, but i hope that works.

@gilfthde
Copy link
Contributor

I can confirm that adding the base_url property into the credentials JSON object works.

@AtzeDeVries
Copy link
Collaborator

@sebastienbrunkyndryl i am going to close it, but feel free to reopen if this issue is not resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants