Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add-revoke-logic-to-grant-and-schema #200

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

olikyr
Copy link

@olikyr olikyr commented Nov 14, 2024

Description of your changes

  1. I added a field called revokePublicOnDb in grant resource; if true, it will revoke from public access to DB; This usually a DBA requirement.
  2. I added a field called isPrivate in schema resource; if true, it will revoke from public access to a schema; This usually a DBA requirement.
  3. I splitted the e2e tests and added tests for postgres resources.

Fixes #189

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

  1. inside the project
make clean
make build
make reviewable
make e2e

I added extensive e2e testing for postgres resources. Privileges are tested by accessing the database created in the cluster and making sql requests.

image image image
  1. outside the project: Pushed built pkg to artifactory and pulled it into a local cluster and submitted claims.

to push:

cd _output/xpkg/linux_amd64
ls ---> provider-sql-v0.0.0-219.g4b26654.xpkg
crossplane xpkg push --package-files="provider-sql-v0.0.0-219.g4b26654.xpkg" my-artifactory/providers/provider-sql:0.1.1

Everything is working as expected.

@olikyr olikyr changed the title Feature/add revoke logic to grant Feature/add-revoke-logic-to-grant-and-schema Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant