Feature/add-revoke-logic-to-grant-and-schema #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
revokePublicOnDb
in grant resource; if true, it will revoke from public access to DB; This usually a DBA requirement.isPrivate
in schema resource; if true, it will revoke from public access to a schema; This usually a DBA requirement.Fixes #189
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
I added extensive e2e testing for postgres resources. Privileges are tested by accessing the database created in the cluster and making sql requests.
to push:
Everything is working as expected.