Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrift-client-ttwitter-filter: ttwitter classes not in package #108

Open
jlai opened this issue Jul 25, 2019 · 3 comments
Open

thrift-client-ttwitter-filter: ttwitter classes not in package #108

jlai opened this issue Jul 25, 2019 · 3 comments

Comments

@jlai
Copy link

jlai commented Jul 25, 2019

Trying to use the ttwitter filter gives this error:

Error: Cannot find module '../ttwitter/com/creditkarma/finagle/thrift'

Probably because the files list in package.json only has dist/main and not dist/ttwitter

@ramakrishna-battala-ck
Copy link
Contributor

Hi @jlai,
Can I get how ttwitter filter is being used in your use case.

@jlai
Copy link
Author

jlai commented Oct 8, 2019

Using it as documented in the readme, e.g.

import {ThriftClientTTwitterFilter} from '@creditkarma/thrift-client-ttwitter-filter';

and connection.register(ThriftClientTTwitterFilter(filterOptions))

It's a packaging issue. Fixing it should be as simple as adding dist/ttwitter to https://github.com/creditkarma/thrift-server/blob/master/packages/thrift-client-ttwitter-filter/package.json

@niodice
Copy link

niodice commented Nov 22, 2024

Added a PR with that suggestion here - #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants