Bump Go version up to 1.21 #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Sorry for the delay!
Some changes are also needed in other Dockerfiles. See https://github.com/crazy-max/diun/pull/858/files as reference. Might also need to bump golangci-lint like docker/buildx#2084
|
No worries. New Nomad version is only just in RC, so I haven't been in a hurry. |
|
|
crazy-max
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Needs docker buildx bake vendor: https://github.com/crazy-max/diun/actions/runs/7094592552/job/19310127792?pr=1026#step:4:388 (might need a rebase as well)
Can you also squash your commits please? Thanks!
When the updated version of Nomad client comes out, I'm planning on a patch to upgrade so that communication over unix socket is available, however the latest requires go 1.21. Rather than bundle a go upgrade with the Nomad change, I thought it best to split up and make sure any potential issues or concerns with the go version are addressed first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the updated version of Nomad client comes out, I'm planning on a patch to upgrade so that communication over unix socket is available, however the latest requires go 1.21. Rather than bundle a go upgrade with the Nomad change, I thought it best to split up and make sure any potential issues or concerns with the go version are addressed first.
If preferred, I can also close this and instead bundle it with the Nomad upgrade PR.