Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Superset: Use Python 3.12 on CI #336

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 27, 2024

About

Probing Apache Superset with Python 3.12.

-- https://devguide.python.org/versions/

Base automatically changed from amo/rm-superset2 to main February 27, 2024 13:13
@amotl amotl changed the title Apache Superset: Use Python 3.8 and 3.12 on CI Apache Superset: Use Python 3.12 on CI Feb 27, 2024
@amotl amotl force-pushed the amo/superset-py312 branch from 52471dc to 6b0ad69 Compare February 27, 2024 13:20
@amotl amotl force-pushed the amo/superset-py312 branch 2 times, most recently from 3ef096f to 921b434 Compare March 21, 2024 18:04
@amotl amotl force-pushed the amo/superset-py312 branch from 921b434 to 5323288 Compare March 26, 2024 18:00
@amotl amotl force-pushed the amo/superset-py312 branch from 5323288 to 1d1a6cb Compare April 10, 2024 10:57
@amotl amotl force-pushed the amo/superset-py312 branch from 1d1a6cb to a0f152d Compare May 6, 2024 18:54
@amotl amotl force-pushed the amo/superset-py312 branch from a0f152d to e0035fa Compare June 18, 2024 17:00
@amotl amotl force-pushed the amo/superset-py312 branch from e0035fa to d693f7f Compare July 10, 2024 18:53
@amotl amotl force-pushed the amo/superset-py312 branch from d693f7f to 345bfff Compare August 5, 2024 17:46
@amotl amotl force-pushed the amo/superset-py312 branch from 345bfff to 041f9d1 Compare October 24, 2024 16:02
@cla-bot cla-bot bot added the cla-signed label Oct 24, 2024
@amotl amotl force-pushed the amo/superset-py312 branch from 041f9d1 to eace67c Compare November 20, 2024 20:00
@amotl
Copy link
Member Author

amotl commented Nov 20, 2024

Hi @villebro,

may I humbly ask you if you have any idea why this job, that aims to start using Python 3.12 on the test matrix, fails on CI/GHA with ModuleNotFoundError: No module named 'distutils' 1? Is it something related to our CI setup, or is Apache Superset not compatible with Python 3.12 yet?

With kind regards,
Andreas.

Footnotes

  1. https://github.com/crate/cratedb-examples/actions/runs/11940819371/job/33284315049?pr=336#step:6:197

@amotl
Copy link
Member Author

amotl commented Nov 20, 2024

Apparently, the job is failing when trying to install NumPy 1.23.5, which does not install well on Python 3.12.

Collecting numpy==1.23.5 (from apache-superset==3.*)

-- https://github.com/crate/cratedb-examples/actions/runs/11940819371/job/33284315049?pr=336#step:6:87

Details

$ python -V
Python 3.12.7
$ uv pip install numpy==1.23.5

Resolved 1 package in 5ms
error: Failed to prepare distributions
  Caused by: Failed to download and build `numpy==1.23.5`
  Caused by: Build backend failed to determine requirements with `build_wheel()` (exit status: 1)

[stderr]
Traceback (most recent call last):
  File "<string>", line 8, in <module>
  File "/Users/amo/.cache/uv/builds-v0/.tmpUqrhkg/lib/python3.12/site-packages/setuptools/__init__.py", line 10, in <module>
    import distutils.core
ModuleNotFoundError: No module named 'distutils'
  Caused by: distutils was removed from the standard library in Python 3.12. Consider adding a constraint (like `numpy >1.23.5`) to avoid building a version of numpy that depends on distutils.

@amotl
Copy link
Member Author

amotl commented Nov 20, 2024

We have been able to dig out the corresponding ticket.

@amotl
Copy link
Member Author

amotl commented Nov 20, 2024

NumPy 1.26 is available for Python 3.12, so maybe upgrading to that version from NumPy 1.23 might be feasible, because it's not too different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant