Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shards view #711

Open
amotl opened this issue Mar 5, 2021 · 2 comments
Open

Improve shards view #711

amotl opened this issue Mar 5, 2021 · 2 comments
Labels
complexity: no estimate feature: shards Feature request related to the shards view feature

Comments

@amotl
Copy link
Member

amotl commented Mar 5, 2021

Hi there.

Currently, when navigating to the the "Shards" view, Admin UI should display a message like There are no shards. on an empty database where no tables or shards have been created yet.

While Admin UI expects a zero-length result to display this message, CrateDB returns a result with one record. crate/crate#11089 is the respective issue on its issue tracker.

With kind regards,
Andreas.

@nomicode nomicode added the bug label Mar 10, 2021
@amotl
Copy link
Member Author

amotl commented Jun 3, 2022

The suggestion by @mfussenegger was to use an INNER JOIN here, see crate/crate#11089 (comment).

@seut seut added feature and removed bug labels Aug 29, 2022
@seut
Copy link
Member

seut commented Aug 29, 2022

I've changed this from bug to feature as the current shard view is not broken with empty tables. Showing an explicit message that no shards exists is indeed an improvement but current situation is not buggy.

@seut seut added complexity: no estimate feature: shards Feature request related to the shards view labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: no estimate feature: shards Feature request related to the shards view feature
Projects
None yet
Development

No branches or pull requests

3 participants