-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for fixup! {conventional}
#392
Comments
That is an interesting one because, technically, it isn't a Conventional Commit anymore but that only matters if this isn't a transient state. |
Completely agree, it is just a transient state, but it is a common workflow. For example, I might be working on a PR with a few logically distinct commits, and I realise that one of the earlier commits has an error. I will create a While implementing this, it should be noted that the same logic should apply for Depending on how deep you want to go with this implementation, the ideal scenario would be to have the option to allow/forbid |
If this is something you would be happy to see added to committed, I would be happy to work on the feature. I might not have much time in the next week or so, but I could start end of next week or so. |
To clarify, are you pushing your fixups or only keeping them local? I've been considering some way to distinguish between local runs and CI runs. For example, I regularly have a WIP commit but I'd want CI to fail if thats present. |
#394 jumps the gun. I did not say we were good for going forward. I was looking for a better understanding of the overall workflow to better understand what should happen. |
No worries! |
Within a PR, such commits might very well exist; but they should not land in the long lived branch. This could be either because multiple people are working on the same PR, and therefore performing a rebase would be too disruptive. Alternatively, I might intend to squash-and-rebase the PR anyway, in which case the commits in the PR are effectively irrelevant. I'll leave you reopen this if/when you want this implemented. If you have no intentions of doing so, let me know and I'll create a fork for my use cases. |
Just because its undecided, doesn't mean it should be closed. For me, closing is for its rejected outright. I do not generally explore rejected issues for re-evaluating opening them. |
It would appear to me that the following combination of configuration options
Should allow for fixup to conventional commits. Unfortunately, this is not what is observed:
My expectation is that a fixup to a conventional commit should be allowed, and that committed should verify the message to be of the form
fixup! type: description
.The text was updated successfully, but these errors were encountered: